* [patch] kill warning in sk98lin
@ 2004-08-28 1:18 Matthew Galgoci
2004-08-28 1:21 ` David S. Miller
2004-08-28 8:53 ` Christoph Hellwig
0 siblings, 2 replies; 6+ messages in thread
From: Matthew Galgoci @ 2004-08-28 1:18 UTC (permalink / raw)
To: netdev, jgarzik
Fix up a warning in sk98lin:
--- drivers/net/sk98lin/skge.c.orig 2004-08-27 21:01:33.447576657 -0400
+++ drivers/net/sk98lin/skge.c 2004-08-27 21:06:07.199406778 -0400
@@ -788,8 +788,9 @@
cards = skge_probe();
if (cards == 0) {
printk("sk98lin: No adapter found.\n");
+ cards = -ENODEV;
}
- return cards ? 0 : -ENODEV;
+ return cards;
} /* skge_init_module */
--
Matthew Galgoci
System Administrator and Sr. Manager of Ruminants
Red Hat, Inc
919.754.3700 x44155
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] kill warning in sk98lin
2004-08-28 1:18 [patch] kill warning in sk98lin Matthew Galgoci
@ 2004-08-28 1:21 ` David S. Miller
2004-08-28 1:23 ` Matthew Galgoci
2004-08-28 8:53 ` Christoph Hellwig
1 sibling, 1 reply; 6+ messages in thread
From: David S. Miller @ 2004-08-28 1:21 UTC (permalink / raw)
To: Matthew Galgoci; +Cc: netdev, jgarzik
On Fri, 27 Aug 2004 21:18:57 -0400 (EDT)
Matthew Galgoci <mgalgoci@redhat.com> wrote:
> Fix up a warning in sk98lin:
Why does it warn? Please provide the warning when fixing
bugs of this nature, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] kill warning in sk98lin
2004-08-28 1:21 ` David S. Miller
@ 2004-08-28 1:23 ` Matthew Galgoci
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Galgoci @ 2004-08-28 1:23 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, jgarzik
On Fri, 27 Aug 2004, David S. Miller wrote:
> Date: Fri, 27 Aug 2004 18:21:00 -0700
> From: David S. Miller <davem@davemloft.net>
> To: Matthew Galgoci <mgalgoci@redhat.com>
> Cc: netdev@oss.sgi.com, jgarzik@pobox.com
> Subject: Re: [patch] kill warning in sk98lin
>
> On Fri, 27 Aug 2004 21:18:57 -0400 (EDT)
> Matthew Galgoci <mgalgoci@redhat.com> wrote:
>
> > Fix up a warning in sk98lin:
>
> Why does it warn? Please provide the warning when fixing
> bugs of this nature, thanks.
Sorry 'bout that.
Module sk98lin cannot be unloaded due to unsafe usage in drivers/net/sk98lin/skge.c:792
--
Matthew Galgoci
System Administrator and Sr. Manager of Ruminants
Red Hat, Inc
919.754.3700 x44155
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] kill warning in sk98lin
2004-08-28 1:18 [patch] kill warning in sk98lin Matthew Galgoci
2004-08-28 1:21 ` David S. Miller
@ 2004-08-28 8:53 ` Christoph Hellwig
2004-08-28 8:55 ` David S. Miller
1 sibling, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2004-08-28 8:53 UTC (permalink / raw)
To: Matthew Galgoci; +Cc: netdev, jgarzik
On Fri, Aug 27, 2004 at 09:18:57PM -0400, Matthew Galgoci wrote:
>
> Fix up a warning in sk98lin:
The code you're patch is gone in current BK.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] kill warning in sk98lin
2004-08-28 8:53 ` Christoph Hellwig
@ 2004-08-28 8:55 ` David S. Miller
2004-08-28 11:25 ` Matthew Galgoci
0 siblings, 1 reply; 6+ messages in thread
From: David S. Miller @ 2004-08-28 8:55 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: mgalgoci, netdev, jgarzik
On Sat, 28 Aug 2004 09:53:56 +0100
Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Aug 27, 2004 at 09:18:57PM -0400, Matthew Galgoci wrote:
> >
> > Fix up a warning in sk98lin:
>
> The code you're patch is gone in current BK.
I believe he's patching against 2.4.x
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] kill warning in sk98lin
2004-08-28 8:55 ` David S. Miller
@ 2004-08-28 11:25 ` Matthew Galgoci
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Galgoci @ 2004-08-28 11:25 UTC (permalink / raw)
To: David S. Miller; +Cc: Christoph Hellwig, netdev, jgarzik
On Sat, 28 Aug 2004, David S. Miller wrote:
> Date: Sat, 28 Aug 2004 01:55:17 -0700
> From: David S. Miller <davem@davemloft.net>
> To: Christoph Hellwig <hch@infradead.org>
> Cc: mgalgoci@redhat.com, netdev@oss.sgi.com, jgarzik@pobox.com
> Subject: Re: [patch] kill warning in sk98lin
>
> On Sat, 28 Aug 2004 09:53:56 +0100
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > On Fri, Aug 27, 2004 at 09:18:57PM -0400, Matthew Galgoci wrote:
> > >
> > > Fix up a warning in sk98lin:
> >
> > The code you're patch is gone in current BK.
>
> I believe he's patching against 2.4.x
Actually it was 2.6.8.1, but hey, if it's gone in current bk, great!
--
Matthew Galgoci
System Administrator and Sr. Manager of Ruminants
Red Hat, Inc
919.754.3700 x44155
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-08-28 11:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-28 1:18 [patch] kill warning in sk98lin Matthew Galgoci
2004-08-28 1:21 ` David S. Miller
2004-08-28 1:23 ` Matthew Galgoci
2004-08-28 8:53 ` Christoph Hellwig
2004-08-28 8:55 ` David S. Miller
2004-08-28 11:25 ` Matthew Galgoci
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).