From: "David S. Miller" <davem@davemloft.net>
To: Andi Kleen <ak@suse.de>
Cc: vatsa@in.ibm.com, davem@redhat.com, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org, dipankar@in.ibm.com,
paulmck@us.ibm.com
Subject: Re: [RFC] Use RCU for tcp_ehash lookup
Date: Wed, 1 Sep 2004 22:43:06 -0700 [thread overview]
Message-ID: <20040901224306.7dd80458.davem@davemloft.net> (raw)
In-Reply-To: <20040831135419.GA17642@wotan.suse.de>
On Tue, 31 Aug 2004 15:54:20 +0200
Andi Kleen <ak@suse.de> wrote:
> And it should also fix the performance problems with
> cat /proc/net/tcp on ppc64/ia64 for large hash tables because the rw locks
> are gone.
Time to convert netstat et al. over the netlink too.
> > - I presume that one of the reasons for keeping the hash table so big is to
> > keep lock contention low (& to reduce the size of hash chains). If the lookup
> > is made lock-free, then could the size of the hash table be reduced (without
> > adversely impacting performance)?
>
> Definitely worth trying IMHO. The current hash tables are far
> too big. I would do that as followon patches though.
The hashes are big to make the hash effective, not to help the locking
contention.
next prev parent reply other threads:[~2004-09-02 5:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-31 12:59 [RFC] Use RCU for tcp_ehash lookup Srivatsa Vaddagiri
2004-08-31 13:04 ` Srivatsa Vaddagiri
2004-08-31 13:12 ` Srivatsa Vaddagiri
2004-08-31 13:54 ` Andi Kleen
2004-09-01 11:36 ` Srivatsa Vaddagiri
2004-09-02 5:45 ` David S. Miller
2004-09-02 21:19 ` Andi Kleen
2004-09-02 5:43 ` David S. Miller [this message]
2004-09-02 5:41 ` David S. Miller
2004-09-02 14:04 ` Srivatsa Vaddagiri
2004-09-02 16:31 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040901224306.7dd80458.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@suse.de \
--cc=davem@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=paulmck@us.ibm.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).