From: margitsw@t-online.de (Margit Schubert-While)
To: netdev@oss.sgi.com
Cc: janitor@sternwelten.at
Subject: Re: [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msleep()
Date: Thu, 2 Sep 2004 19:30:18 +0200 [thread overview]
Message-ID: <200409021930.18414.margitsw@t-online.de> (raw)
On Thu, 02 Sep 2004, Nishanth scribeth:
> A grep of drivers/net/wireless/prism54 for schedule_timeout showed three
> occurrences (in 2.6.9-rc1-bk7):
> islpci_dev.c: schedule_timeout(50*HZ/1000);
> islpci_dev.c: remaining = schedule_timeout(HZ);
> islpci_mgt.c: timeleft = schedule_timeout(wait_cycle_jiffies);
> The first is removed by my patch.
> The second & third are potentially bugs as there is no
> set_current_state() preceding the call to schedule_timeout(). As per the
> source:
Nope, look a few lines above:
DEFINE_WAIT() and prepare_to_wait().
Margit
next reply other threads:[~2004-09-02 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-02 17:30 Margit Schubert-While [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-02 17:52 [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msleep() Margit Schubert-While
2004-09-02 18:27 ` Nishanth Aravamudan
2004-09-02 10:21 Margit Schubert-While
2004-09-02 9:35 Margit Schubert-While
2004-09-02 10:03 ` maximilian attems
2004-09-02 6:50 Margit Schubert-While
2004-09-02 8:24 ` [Kernel-janitors] " maximilian attems
2004-09-02 16:09 ` Nishanth Aravamudan
2004-09-01 21:06 janitor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409021930.18414.margitsw@t-online.de \
--to=margitsw@t-online.de \
--cc=janitor@sternwelten.at \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).