From: "David S. Miller" <davem@davemloft.net>
To: David Woodhouse <dwmw2@infradead.org>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] Compat32 setsockopt overzealous conversions
Date: Tue, 7 Sep 2004 14:06:49 -0700 [thread overview]
Message-ID: <20040907140649.42eaa278.davem@davemloft.net> (raw)
In-Reply-To: <1094563381.5122.8.camel@localhost.localdomain>
On Tue, 07 Sep 2004 14:23:00 +0100
David Woodhouse <dwmw2@infradead.org> wrote:
> compat_sys_setsockopt() is a little overzealous about converting 32-bit
> stuff into 64-bit. It should match on level _and_ optname, not just
> optname. Currently it eats the IPV6_V6ONLY sockopt because its value
> (26) happens to match SO_ATTACH_FILTER.
>
> This makes it at least check 'level' for everything but
> IPT_SO_SET_REPLACE == IPT6_SO_SET_REPLACE, because that does seem to be
> the same in different levels. But do_netfilter_replace() is another can
> of worms entirely -- it doesn't actually work either, because some
> netfilter modules (like ipt_limit) include kernel-only bits which change
> size in the structure they share with userspace.
Thanks, applied.
I know it's a pain in the ass, but could you cook up
a 2.4.x version? Thanks.
next prev parent reply other threads:[~2004-09-07 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 13:23 [PATCH] Compat32 setsockopt overzealous conversions David Woodhouse
2004-09-07 21:06 ` David S. Miller [this message]
2004-09-09 7:53 ` David Woodhouse
2004-09-10 23:43 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040907140649.42eaa278.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).