From: "David S. Miller" <davem@davemloft.net>
To: James Chapman <jchapman@katalix.com>
Cc: netdev@oss.sgi.com, kleptog@svana.org
Subject: Re: PPP-over-L2TP kernel support, patch for review
Date: Tue, 7 Sep 2004 15:56:57 -0700 [thread overview]
Message-ID: <20040907155657.2ab6a4bb.davem@davemloft.net> (raw)
In-Reply-To: <1094471956.413c5114de2d7@www.katalix.com>
On Mon, 6 Sep 2004 12:59:16 +0100
James Chapman <jchapman@katalix.com> wrote:
> I'm working towards having this driver integrated into the kernel
> tree. Comments?
Only two major comments:
1) Uses own linked list implementations. Please use
linux/list.h interfaces for this.
2) Does this:
struct sockaddr_pppox {
sa_family_t sa_family; /* address family, AF_PPPOX */
unsigned int sa_protocol; /* protocol identifier */
union{
struct pppoe_addr pppoe;
+ struct pppol2tp_addr pppol2tp;
}sa_addr;
}__attribute__ ((packed));
Change the size of sockaddr_pppox on any platform? If so, you'll
break pppox userspace with this change so we'd need find another
way to do it.
Thanks.
next prev parent reply other threads:[~2004-09-07 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-06 11:59 PPP-over-L2TP kernel support, patch for review James Chapman
2004-09-07 22:56 ` David S. Miller [this message]
2004-09-08 7:32 ` Martijn van Oosterhout
2004-09-08 8:17 ` Herbert Xu
2004-09-08 8:38 ` Martijn van Oosterhout
2004-09-08 8:46 ` Herbert Xu
2004-09-08 9:04 ` Martijn van Oosterhout
2004-09-08 10:04 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2004-09-06 11:55 James Chapman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040907155657.2ab6a4bb.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=kleptog@svana.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).