From: Thomas Graf <tgraf@suug.ch>
To: "David S. Miller" <davem@davemloft.net>
Cc: hadi@cyberus.ca, eric.lemoine@gmail.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6 NET] Adjust RTATTR_MAX to IFLA_* changes
Date: Thu, 9 Sep 2004 19:49:43 +0200 [thread overview]
Message-ID: <20040909174943.GA19155@postel.suug.ch> (raw)
In-Reply-To: <20040909103149.248a603e.davem@davemloft.net>
* David S. Miller <20040909103149.248a603e.davem@davemloft.net> 2004-09-09 10:31
> On Thu, 9 Sep 2004 18:31:31 +0200
> Thomas Graf <tgraf@suug.ch> wrote:
>
> > IFLA_MAX is now bigger than RTA_MAX with the latest changes in IFLA_*.
> > Adjust RTATTR to point to IFLA_MAX to have big enough buffer in
> > rtnetlink_rcv_msg.
>
> Ok, this is going to get silly if some other attribute gets
> larger than IFLA_* next.
>
> We should just compute this thing at run time.
> Else, if the macro can't be deleted because there
> are non-trivial other uses, use some expression
> involving max().
>
> I just checked iproute2 sources and it does not reference
> this thing, so probably best to kill it off, like so.
This is even better, works fine for me.
next prev parent reply other threads:[~2004-09-09 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-09 16:31 [PATCH 2.6 NET] Adjust RTATTR_MAX to IFLA_* changes Thomas Graf
2004-09-09 17:31 ` David S. Miller
2004-09-09 17:49 ` Thomas Graf [this message]
2004-09-09 17:53 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040909174943.GA19155@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=eric.lemoine@gmail.com \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).