netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: fork0@users.sourceforge.net, linux-kernel@vger.kernel.org,
	netdev@oss.sgi.com
Subject: Re: 2.6.9-rc1+bk: assertion tcp_get_pcount failed at net/ipv4/tcp_input.c
Date: Thu, 9 Sep 2004 22:25:42 -0700	[thread overview]
Message-ID: <20040909222542.7a30c0e4.davem@davemloft.net> (raw)
In-Reply-To: <20040910033055.GA26790@gondor.apana.org.au>

On Fri, 10 Sep 2004 13:30:55 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Thu, Sep 09, 2004 at 11:12:33AM +0000, Alex Riesen wrote:
> > The box froze after being left for some time (some 10 hours) unattended.
> > The only thing in I could find in logs was:
> > 
> > Sep  8 22:30:18 steel kernel: KERNEL: assertion ((int)tcp_get_pcount(&tp->lost_out) >= 0) failed at net/ipv4/tcp_input.c (2422)
> > Sep  8 22:30:18 steel kernel: Leak l=4294967295 4
> 
> Looks like the factor isn't set early enough.  Can you please check
> that you had the changeset titled
> 
> [TCP]: Make sure SKB tso factor is setup early enough.
> 
> from davem?
> 
> If you did, then please apply the following patch and tell us what
> the resulting messages.

Herbert did you see my division fix I made today for
tso_factor calculation?  I was dividing by the TSO mss
instead of the normal one :-)

I think that is the cause of these problems.  It was
definitely the cause of a BUG() trap hit in tcp_transmit_skb()
that someone else reported in the past day.

  reply	other threads:[~2004-09-10  5:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-09 11:12 2.6.9-rc1+bk: assertion tcp_get_pcount failed at net/ipv4/tcp_input.c Alex Riesen
2004-09-10  3:30 ` Herbert Xu
2004-09-10  5:25   ` David S. Miller [this message]
2004-09-10  5:56     ` Herbert Xu
2004-09-10  6:39     ` Nivedita Singhvi
2004-09-10 21:08       ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040909222542.7a30c0e4.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fork0@users.sourceforge.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).