netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: David Woodhouse <dwmw2@infradead.org>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] Compat32 setsockopt overzealous conversions
Date: Fri, 10 Sep 2004 16:43:54 -0700	[thread overview]
Message-ID: <20040910164354.3cdffa59.davem@davemloft.net> (raw)
In-Reply-To: <1094716398.15909.27.camel@localhost.localdomain>

On Thu, 09 Sep 2004 08:53:18 +0100
David Woodhouse <dwmw2@infradead.org> wrote:

2.4.x patch applied, thanks David.

> Back in the real world of 2.6, we REALLY do need to stop trying to do
> all this in a sockopt syscall wrapper, and instead pass down a 32/64 bit
> flag to the code which actually handles the sockopt -- although the
> optlen ought to be sufficient for the _majority_ of cases. Or maybe we
> should handle it like we do ioctls? 

That latter idea (doing it like ioctls) is an option, and in
fact I like it since it would allow us to push the complicated
netfilter translators into the netfilter code.

      reply	other threads:[~2004-09-10 23:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-07 13:23 [PATCH] Compat32 setsockopt overzealous conversions David Woodhouse
2004-09-07 21:06 ` David S. Miller
2004-09-09  7:53   ` David Woodhouse
2004-09-10 23:43     ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040910164354.3cdffa59.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dwmw2@infradead.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).