netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: jt@hpl.hp.com
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6 NET] Device name changing via rtnetlink
Date: Fri, 10 Sep 2004 22:22:35 +0200	[thread overview]
Message-ID: <20040910202235.GK20088@postel.suug.ch> (raw)
In-Reply-To: <20040910201302.GA16556@bougret.hpl.hp.com>

* Jean Tourrilhes <20040910201302.GA16556@bougret.hpl.hp.com> 2004-09-10 13:13
> On Fri, Sep 10, 2004 at 10:06:44PM +0200, Thomas Graf wrote:
> > * Jean Tourrilhes <20040910195003.GA13912@bougret.hpl.hp.com> 2004-09-10 12:50
> > > Thomas Graf wrote :
> > > > 
> > > > Allows changing of device name via rtnetlink. Last bit needed to do full
> > > > link configuration via rtnetlink.
> > > > 
> > > > Signed-off-by: Thomas Graf <tgraf@suug.ch>
> > > 
> > > 	This does not work, because you don't return the new name to
> > > user space. If the new name is a pattern, such as "eth%d" or "wlan%d",
> > > you absolutely need to return the new instanciated device name to user
> > > space so that userspace doesn't loose track of the device.
> > 
> > The ifindex stays the same, therefore the user space application can
> > simply dump the link list and fetch the new interface name.
> 
> 	It's so simple to return the new name, so why not do it ?
> There is no need to make applications more complex.

Oh, I didn't realize that, can you enlighten me?

> > It would
> > theoretically be possible to provide the new name via an ACK but
> > this would break the RFC.
> 
> 	What do you mean, break the RFC ?

I can think of 2 ways implementing this:

1) Send an ACK and change IFLA_IFNAME in the original message. However,
   RFC 3549 specifies it to be the old message so user space
   applications can directly reuse it (forward, redirect, log, ...)

2) Implement NETDEV_CHANGE, I was actually about to implement this
   but it's not directly related to this change and requires the same
   effort by the user space application has refetching the link list.

  reply	other threads:[~2004-09-10 20:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-10 19:50 [PATCH 2.6 NET] Device name changing via rtnetlink Jean Tourrilhes
2004-09-10 20:06 ` Thomas Graf
2004-09-10 20:13   ` Jean Tourrilhes
2004-09-10 20:22     ` Thomas Graf [this message]
2004-09-10 20:31       ` jamal
2004-09-10 20:32       ` Jean Tourrilhes
2004-09-10 20:43         ` Thomas Graf
2004-09-10 22:58           ` jamal
2004-09-10 23:17             ` Thomas Graf
2004-09-11  2:01               ` jamal
2004-09-11 13:44                 ` Thomas Graf
2004-09-11 19:59                   ` jamal
2004-09-11 22:06                     ` Thomas Graf
2004-09-12 17:27                       ` jamal
2004-09-13  0:20                         ` David S. Miller
2004-09-10 23:04           ` David S. Miller
  -- strict thread matches above, loose matches on Subject: below --
2004-09-10 13:36 Thomas Graf
2004-09-10 14:00 ` YOSHIFUJI Hideaki / 吉藤英明
2004-09-10 14:28   ` Thomas Graf
2004-09-10 14:31     ` YOSHIFUJI Hideaki / 吉藤英明

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040910202235.GK20088@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=jt@hpl.hp.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).