From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: hadi@cyberus.ca, ak@suse.de, herbert@gondor.apana.org.au,
netdev@oss.sgi.com
Subject: Re: [PATCH] NETIF_F_LLTX for devices 2
Date: Sun, 12 Sep 2004 05:57:30 -0400 [thread overview]
Message-ID: <20040912095730.GA11484@havoc.gtf.org> (raw)
In-Reply-To: <20040911174535.2acbb957.davem@davemloft.net>
On Sat, Sep 11, 2004 at 05:45:35PM -0700, David S. Miller wrote:
> I think Andi made the right choice for his implementation.
> And frankly I don't what is worrying about the
> "-1" return value, it can occur in only one spot in a very
> specific controlled case and it's behavior is incredibly well
> defined (if not by accurate comments then by the code itself :-)
Not commenting on the overall issue, but just the return code:
We already have net drivers getting the current TWO return codes wrong.
Adding one more -magic number- to the mix is just plain silly.
1. Add constants
2. Add clear, unambiguous documentation describing all three return codes
3. (janitor) use constants
Lacking #1 and #2 are design flaws that ignore existing problems,
and create new ones. Luckily #1 and #2 are simple, human-friendly
fixes.
Jeff
next prev parent reply other threads:[~2004-09-12 9:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 12:05 [PATCH] NETIF_F_LLTX for devices 2 Andi Kleen
2004-09-07 21:39 ` David S. Miller
2004-09-07 21:53 ` jamal
2004-09-08 6:51 ` Andi Kleen
2004-09-08 7:07 ` Herbert Xu
2004-09-08 7:24 ` Andi Kleen
2004-09-08 7:47 ` jamal
2004-09-08 20:47 ` David S. Miller
2004-09-10 13:33 ` jamal
2004-09-10 23:02 ` David S. Miller
2004-09-11 14:21 ` Andi Kleen
2004-09-11 20:15 ` jamal
2004-09-12 0:45 ` David S. Miller
2004-09-12 9:57 ` Jeff Garzik [this message]
2004-09-12 10:01 ` Jeff Garzik
2004-09-12 10:25 ` Andi Kleen
2004-09-12 11:03 ` Francois Romieu
2004-09-13 0:13 ` David S. Miller
2004-09-12 16:16 ` Jeff Garzik
2004-09-12 17:34 ` jamal
2004-09-13 0:06 ` Jeff Garzik
2004-09-13 0:10 ` David S. Miller
2004-09-13 2:52 ` Andrew Grover
2004-09-13 6:59 ` Andi Kleen
2004-09-13 16:10 ` Jeff Garzik
2004-09-13 0:12 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040912095730.GA11484@havoc.gtf.org \
--to=jgarzik@pobox.com \
--cc=ak@suse.de \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).