From: Francois Romieu <romieu@fr.zoreil.com>
To: Andi Kleen <ak@suse.de>
Cc: "David S. Miller" <davem@davemloft.net>,
hadi@cyberus.ca, herbert@gondor.apana.org.au, netdev@oss.sgi.com
Subject: Re: [PATCH] NETIF_F_LLTX for devices 2
Date: Sun, 12 Sep 2004 13:03:20 +0200 [thread overview]
Message-ID: <20040912110320.GA21197@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20040912102529.GA27096@wotan.suse.de>
Andi Kleen <ak@suse.de> :
[...]
> I wasn't aware of Documentation/netdevices.txt, but I agree it
> would be a good idea to update it. Patch for that attached.
> DaveM, please apply.
I have modified your patch so as to include a bit from a message
of Jamal on netdev the 05/07/2004.
diff -u linux-2.6.8-work/Documentation/networking/netdevices.txt-o linux-2.6.8-work/Documentation/networking/netdevices.txt
--- linux-2.6.8-work/Documentation/networking/netdevices.txt-o 2004-03-21 21:12:11.000000000 +0100
+++ linux-2.6.8-work/Documentation/networking/netdevices.txt 2004-09-12 12:24:02.000000000 +0200
@@ -43,8 +43,21 @@
dev->hard_start_xmit:
Synchronization: dev->xmit_lock spinlock.
+ When the driver sets NETIF_F_LLTX in dev->features this will be
+ called without holding xmit_lock. In this case the driver
+ has to lock by itself when needed. It is recommended to use a try lock
+ for this and return -1 when the spin lock fails.
+ The locking there should also properly protect against
+ set_multicast_list
Context: BHs disabled
Notes: netif_queue_stopped() is guaranteed false
+ Return codes:
+ o 0 everything ok.
+ o 1 Cannot transmit packet, try later
+ Usually a bug, means queue start/stop flow control is broken in
+ the driver. Note: the driver must NOT put the skb in its DMA ring.
+ o -1 Locking failed, please retry quickly. Only valid when
+ NETIF_F_LLTX is set.
dev->tx_timeout:
Synchronization: dev->xmit_lock spinlock.
next prev parent reply other threads:[~2004-09-12 11:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 12:05 [PATCH] NETIF_F_LLTX for devices 2 Andi Kleen
2004-09-07 21:39 ` David S. Miller
2004-09-07 21:53 ` jamal
2004-09-08 6:51 ` Andi Kleen
2004-09-08 7:07 ` Herbert Xu
2004-09-08 7:24 ` Andi Kleen
2004-09-08 7:47 ` jamal
2004-09-08 20:47 ` David S. Miller
2004-09-10 13:33 ` jamal
2004-09-10 23:02 ` David S. Miller
2004-09-11 14:21 ` Andi Kleen
2004-09-11 20:15 ` jamal
2004-09-12 0:45 ` David S. Miller
2004-09-12 9:57 ` Jeff Garzik
2004-09-12 10:01 ` Jeff Garzik
2004-09-12 10:25 ` Andi Kleen
2004-09-12 11:03 ` Francois Romieu [this message]
2004-09-13 0:13 ` David S. Miller
2004-09-12 16:16 ` Jeff Garzik
2004-09-12 17:34 ` jamal
2004-09-13 0:06 ` Jeff Garzik
2004-09-13 0:10 ` David S. Miller
2004-09-13 2:52 ` Andrew Grover
2004-09-13 6:59 ` Andi Kleen
2004-09-13 16:10 ` Jeff Garzik
2004-09-13 0:12 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040912110320.GA21197@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=ak@suse.de \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).