From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] NETIF_F_LLTX for devices 2 Date: Sun, 12 Sep 2004 12:16:05 -0400 Sender: netdev-bounce@oss.sgi.com Message-ID: <20040912161604.GA23366@havoc.gtf.org> References: <20040908072408.GI27886@wotan.suse.de> <1094629677.1089.155.camel@jzny.localdomain> <20040908134713.1bcd46d3.davem@davemloft.net> <1094823215.1121.129.camel@jzny.localdomain> <20040911142116.GL4431@wotan.suse.de> <1094933731.2343.109.camel@jzny.localdomain> <20040911174535.2acbb957.davem@davemloft.net> <20040912100114.GB11484@havoc.gtf.org> <20040912102529.GA27096@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , hadi@cyberus.ca, herbert@gondor.apana.org.au, netdev@oss.sgi.com Return-path: To: Andi Kleen Content-Disposition: inline In-Reply-To: <20040912102529.GA27096@wotan.suse.de> Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Sun, Sep 12, 2004 at 12:25:29PM +0200, Andi Kleen wrote: > On Sun, Sep 12, 2004 at 06:01:14AM -0400, Jeff Garzik wrote: > > > > Oh and update Documentation/networking/netdevice.txt. > > > > If people are going to screw with the TX path, at least do it right and > > make it non-mysterious for everyone else. > > > > See Al Viro's Documentation/filesystem/directory-locking doc for a > > proper way to document a locking change that potentially affects every > > net driver in the kernel. > > > No it doesn't. It only affects every driver who sets NETIF_F_LLTX. > For drivers that don't set this flag there is no change at all. > Incorrect, you are changing the callsites, which -does- affect every driver. > I wasn't aware of Documentation/netdevices.txt, but I agree it > would be a good idea to update it. Patch for that attached. > DaveM, please apply. Thanks, but still need a patch for return value constants, otherwise you are compounding rather than addressing a current problem. Jeff