From: "David S. Miller" <davem@davemloft.net>
To: Eric Lemoine <eric.lemoine@gmail.com>
Cc: ak@suse.de, davem@redhat.com, netdev@oss.sgi.com
Subject: Re: [PATCH] LLTX for tg3
Date: Sun, 12 Sep 2004 16:45:16 -0700 [thread overview]
Message-ID: <20040912164516.6960ffe8.davem@davemloft.net> (raw)
In-Reply-To: <5cac192f040912100616feb28a@mail.gmail.com>
On Sun, 12 Sep 2004 19:06:26 +0200
Eric Lemoine <eric.lemoine@gmail.com> wrote:
> > Add LLTX suppor to tg3. Locking was already safe for it, so only
> > trivial changes.
>
> tg3_set_rx_mode() (dev->set_multicast_list()) and tg3_start_xmit()
> used to synchronise thanks to dev->lock_xmit. With your LLTX patches
> they don't synchronise anymore (I don't think tg3_set_rx_mode() grabs
> tp->tx_lock) ; isn't it an issue?
You're absolutely right, I've made tg3_set_rx_mode() grab the
tx_lock now too.
Good spotting Eric.
prev parent reply other threads:[~2004-09-12 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 12:18 [PATCH] LLTX for tg3 Andi Kleen
2004-09-12 17:06 ` Eric Lemoine
2004-09-12 23:45 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040912164516.6960ffe8.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@suse.de \
--cc=davem@redhat.com \
--cc=eric.lemoine@gmail.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).