From: "David S. Miller" <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: netdev@oss.sgi.com, vnuorval@tcs.hut.fi
Subject: Re: [BK PATCH] [IPV6] Merge Specification Conformity Improvements
Date: Mon, 13 Sep 2004 15:55:06 -0700 [thread overview]
Message-ID: <20040913155506.4c99d4c8.davem@davemloft.net> (raw)
In-Reply-To: <20040913.231732.94153456.yoshfuji@linux-ipv6.org>
Ok, here are comments :-)
1) wrt. net/core/neighbour.c changes to use time_after() and
similar interfaces. Here is why I didn't do that previously.
I showed this to Alexey some time ago and he made me aware of
some "black magic" in this area. Here is what he told me:
-------------------------------------------------------------
BTW while I remember... Long time ago (when no such macros even existed)
I definitely used some funny technique. Namely, when you definitely
know that some timestamp is growing, now - ts_prev > timeo
is always right thing and time_after(now, ts_prev+timeo) is not.
Unfortunately, I do not remember where exactly. It is sick approach, of course,
but it allowed not to switch to timeval to stamp long living objects.
So, if you will notice such place, it would be better to make it to use
timeval rather than to time_* macros.
-------------------------------------------------------------
2) rt6_dflt_{pointer,lock}
Maybe it would be better to export a function that operates
on these objects rather than the objects themselves. That
way we could keep them and their implementation static to
ip6_fib.c
These are minor issues though, and as I stated I pulled your changes
in already.
Thanks.
next prev parent reply other threads:[~2004-09-13 22:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 14:17 [BK PATCH] [IPV6] Merge Specification Conformity Improvements YOSHIFUJI Hideaki / 吉藤英明
2004-09-13 14:29 ` Pekka Savola
2004-09-13 15:01 ` YOSHIFUJI Hideaki / 吉藤英明
2004-09-13 20:49 ` David S. Miller
2004-09-13 22:55 ` David S. Miller [this message]
2004-09-14 1:19 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040913155506.4c99d4c8.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=vnuorval@tcs.hut.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).