From: "David S. Miller" <davem@davemloft.net>
To: Fernando Gont <fernando@gont.com.ar>
Cc: netdev@oss.sgi.com
Subject: Re: ICMP attacks against TCP
Date: Mon, 13 Sep 2004 16:01:33 -0700 [thread overview]
Message-ID: <20040913160133.69185327.davem@davemloft.net> (raw)
In-Reply-To: <4.3.2.7.2.20040912223315.00df2890@mail.daleclick.com>
On Sun, 12 Sep 2004 22:40:04 -0300
Fernando Gont <fernando@gont.com.ar> wrote:
> There are some other work-arounds (for example, ignoring ICMP Source Quench
> messages) are not implemented in Linux, though.
I have no problem changing Linux to ignore these ICMP Source Quench
messages, I completely agree with the draft. I've made the
change in both my 2.4.x and 2.6.x trees as follows:
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/09/13 15:43:14-07:00 davem@nuts.davemloft.net
# [TCP]: Just silently ignore ICMP Source Quench messages.
#
# Recommended by draft-gont-tcpm-icmp-attacks-01.txt
#
# Signed-off-by: David S. Miller <davem@davemloft.net>
#
# net/ipv4/tcp_ipv4.c
# 2004/09/13 15:42:33-07:00 davem@nuts.davemloft.net +1 -5
# [TCP]: Just silently ignore ICMP Source Quench messages.
#
diff -Nru a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
--- a/net/ipv4/tcp_ipv4.c 2004-09-13 15:44:01 -07:00
+++ b/net/ipv4/tcp_ipv4.c 2004-09-13 15:44:01 -07:00
@@ -1033,11 +1033,7 @@
switch (type) {
case ICMP_SOURCE_QUENCH:
- /* This is deprecated, but if someone generated it,
- * we have no reasons to ignore it.
- */
- if (!sock_owned_by_user(sk))
- tcp_enter_cwr(tp);
+ /* Just silently ignore these. */
goto out;
case ICMP_PARAMETERPROB:
err = EPROTO;
next prev parent reply other threads:[~2004-09-13 23:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 1:40 ICMP attacks against TCP Fernando Gont
2004-09-13 23:01 ` David S. Miller [this message]
2004-09-16 19:34 ` Fernando Gont
2004-09-13 23:02 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040913160133.69185327.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fernando@gont.com.ar \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).