From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jmorris@redhat.com, yoshfuji@linux-ipv6.org, netdev@oss.sgi.com
Subject: Re: [RTNETLINK] Convert RTM_* to enum
Date: Tue, 14 Sep 2004 21:38:37 -0700 [thread overview]
Message-ID: <20040914213837.75634b93.davem@davemloft.net> (raw)
In-Reply-To: <20040915034748.GA952@gondor.apana.org.au>
On Wed, 15 Sep 2004 13:47:48 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Tue, Sep 14, 2004 at 11:38:21PM -0400, James Morris wrote:
> >
> > Having the enums as well as the defines is messy, I wonder if it's really
> > worth it.
>
> I think the enum is definitely worth it for reducing the churn on
> the MAX value.
>
> I personally don't see a point to the defines since the user-space
> appliations should not change behaviour based on compile-time
> settings. However, others seem to have a different opinion on that.
Right. If we start using defines we have to keep them around.
I know it's bogus for people to ifdef this stuff, but we know
they do, and it's in bad taste to knowingly break stuff like that.
Anyways, I'll apply your patch Herbert, thanks.
next prev parent reply other threads:[~2004-09-15 4:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 2:09 [RTNETLINK] Convert RTM_* to enum Herbert Xu
2004-09-15 3:38 ` James Morris
2004-09-15 3:47 ` Herbert Xu
2004-09-15 4:38 ` David S. Miller [this message]
2004-09-15 4:45 ` Herbert Xu
2004-09-15 4:46 ` David S. Miller
2004-09-16 9:08 ` [RTNETLINK] Tunnel config via netlink (Was Re: Convert RTM_* to enum) Ville Nuorvala
2004-09-16 11:13 ` Pekka Savola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914213837.75634b93.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).