From: "David S. Miller" <davem@redhat.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@oss.sgi.com
Subject: Re: [RFC] inet_opt space saving?
Date: Thu, 16 Sep 2004 13:44:05 -0700 [thread overview]
Message-ID: <20040916134405.4093e659.davem@redhat.com> (raw)
In-Reply-To: <20040914151232.115c3eca@dell_ss3.pdx.osdl.net>
On Tue, 14 Sep 2004 15:12:32 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> It looks like there are lots of wasted bytes in the inet information
> per socket. Does this look right?
I see one error at least.
> + cmsg_flags: 4,
There are 5 bits, not 4.
#define IP_CMSG_PKTINFO 1
#define IP_CMSG_TTL 2
#define IP_CMSG_TOS 4
#define IP_CMSG_RECVOPTS 8
#define IP_CMSG_RETOPTS 16
This is also the number of right shifts, plus one, made
by ip_cmsg_recv().
The rest of your transformations look perfectly fine.
prev parent reply other threads:[~2004-09-16 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 22:12 [RFC] inet_opt space saving? Stephen Hemminger
2004-09-16 20:44 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916134405.4093e659.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).