From: "David S. Miller" <davem@davemloft.net>
To: Ben Greear <greearb@candelatech.com>
Cc: shemminger@osdl.org, Robert.Olsson@data.slu.se, davem@redhat.com,
netdev@oss.sgi.com, hadi@znyx.com
Subject: Re: [PATCH] pktgen handle netdev device getting full.
Date: Thu, 16 Sep 2004 15:59:13 -0700 [thread overview]
Message-ID: <20040916155913.577b878b.davem@davemloft.net> (raw)
In-Reply-To: <414A1AD2.1090109@candelatech.com>
On Thu, 16 Sep 2004 15:59:30 -0700
Ben Greear <greearb@candelatech.com> wrote:
> Stephen Hemminger wrote:
> > I was trying out pktgen on a NIC with an undersized ring, so
> > hard_start_xmit would always return non-zero when full. This caused a slew
> > of console messages. Better to just have pktgen retry in this case.
>
> My understanding is that if the queue is not stopped, then you
> should not get the hard xmit errors. So, in a proper driver,
> you should not see these printks.
That is absolutely correct, that is why Stephen's patch is
not correct (aside from the do_div() part which I'll happily
apply if submitted by itself).
> By the way, is there any interest in adding my patch that also allows
> pktgen to receive packets (and count the statistics, etc)? I know
> DaveM objected to the hook in the skb-receive logic some time back,
> but maybe he has a different opinion now?
I still object to this, it will be abused.
next prev parent reply other threads:[~2004-09-16 22:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 21:43 [PATCH] pktgen handle netdev device getting full Stephen Hemminger
2004-09-16 22:59 ` Ben Greear
2004-09-16 22:59 ` David S. Miller [this message]
2004-09-16 23:20 ` Stephen Hemminger
2004-09-16 23:20 ` David S. Miller
2004-09-16 23:22 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916155913.577b878b.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@redhat.com \
--cc=greearb@candelatech.com \
--cc=hadi@znyx.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).