From: "David S. Miller" <davem@davemloft.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: greearb@candelatech.com, Robert.Olsson@data.slu.se,
davem@redhat.com, netdev@oss.sgi.com, hadi@znyx.com
Subject: Re: [PATCH] pktgen handle netdev device getting full.
Date: Thu, 16 Sep 2004 16:20:30 -0700 [thread overview]
Message-ID: <20040916162030.3a65e7d5.davem@davemloft.net> (raw)
In-Reply-To: <20040916162051.1b55ae5b@dell_ss3.pdx.osdl.net>
On Thu, 16 Sep 2004 16:20:51 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> Well the E1000 fill's it Tx ring and returns TX_BUSY, and on
> SMP can also get TX_LOCKED now. If that happens, the message shows up.
> Several other drivers don't set stopped when ring is almost full, but
> rely on scheduler to do it for them.
TX_LOCKED is special, and actually this points out that pktgen.c
needs to change how it interprets hard_start_xmit() return
values now that TX_LOCKED is possible too.
I'm sorry, is that what your patch was doing? Then it was
correct, please resend.
next prev parent reply other threads:[~2004-09-16 23:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 21:43 [PATCH] pktgen handle netdev device getting full Stephen Hemminger
2004-09-16 22:59 ` Ben Greear
2004-09-16 22:59 ` David S. Miller
2004-09-16 23:20 ` Stephen Hemminger
2004-09-16 23:20 ` David S. Miller [this message]
2004-09-16 23:22 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916162030.3a65e7d5.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@redhat.com \
--cc=greearb@candelatech.com \
--cc=hadi@znyx.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).