From: "David S. Miller" <davem@davemloft.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: jes@wildopensource.com, jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [PATCH] acenic - don't spin in hard_start_xmit when ring fills
Date: Thu, 16 Sep 2004 16:50:42 -0700 [thread overview]
Message-ID: <20040916165042.362a3e79.davem@davemloft.net> (raw)
In-Reply-To: <20040916164206.707204d4@dell_ss3.pdx.osdl.net>
On Thu, 16 Sep 2004 16:42:06 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> NO, the bus just isn't fast enough to keep up with the number of small
> packets I am shoving at it.
>
> You got TX_LOCKED and TX_BUSY confused. The problem is drivers that
> don't check to see if the last packet sent fills the ring and stop
> themselves.
I understand.
But that still makes this change buggy. I believe the two choices
are:
1) Accept this spinning performance characteristic of the
acenic driver.
or
2) Finally give up on acenic's clever lockless scheme and add
the necessary locking + start/stop tx flow control so it
will never have to return TX_BUSY except in absolutely
catastrophic failure cases.
next prev parent reply other threads:[~2004-09-16 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 23:17 [PATCH] acenic - don't spin in hard_start_xmit when ring fills Stephen Hemminger
2004-09-16 23:22 ` David S. Miller
2004-09-16 23:42 ` Stephen Hemminger
2004-09-16 23:50 ` David S. Miller [this message]
2004-09-17 16:02 ` Stephen Hemminger
2004-09-17 18:31 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916165042.362a3e79.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jes@wildopensource.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).