From: "Randy.Dunlap" <rddunlap@osdl.org>
To: <ravinandan.arakali@s2io.com>
Cc: jgarzik@pobox.com, netdev@oss.sgi.com, leonid.grossman@s2io.com,
raghavendra.koushik@s2io.com, rapuru.sriram@s2io.com
Subject: Re: Patch submission for S2io Xframe driver to 2.6 kernel
Date: Thu, 16 Sep 2004 20:58:49 -0700 [thread overview]
Message-ID: <20040916205849.55ce05e5.rddunlap@osdl.org> (raw)
In-Reply-To: <002201c499b4$7c7b60c0$a010100a@S2IOtech.com>
On Mon, 13 Sep 2004 10:09:53 -0700 Ravinandan Arakali wrote:
| Hi Jeff,
| Attached is the patch with the first round comments incorporated.
| In addition, this patch contains
| Some fixes related to 32-bit systems.
| Few fixes related to Rx path in NAPI.
|
| Thanks to all for the comments.
|
| Pls review this patch as well and come back with your comments.
1. typo? first name is still used in source code:
-static char s2io_driver_version[] = "Version 1.0";
+static char s2iO_driver_version[] = "Version 1.1";
2. don't init. globals to 0 -- it's done automatically for you.
(more this weekend....)
--
~Randy
next prev parent reply other threads:[~2004-09-17 3:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-14 0:19 Patch submission for S2io Xframe driver to 2.6 kernel Ravinandan Arakali
2004-08-14 4:27 ` TCP hardware assists Leonid Grossman
2004-08-21 6:21 ` Patch submission for S2io Xframe driver to 2.6 kernel Randy.Dunlap
2004-08-21 23:43 ` Francois Romieu
2004-08-28 23:36 ` Jeff Garzik
2004-08-29 5:53 ` Leonid Grossman
2004-08-30 17:25 ` Ravinandan Arakali
2004-09-13 17:09 ` Ravinandan Arakali
2004-09-17 0:38 ` Jeff Garzik
2004-09-17 0:53 ` Ravinandan Arakali
2004-09-17 0:52 ` Jeff Garzik
2004-09-17 3:07 ` Randy.Dunlap
2004-09-28 0:42 ` Ravinandan Arakali
2004-09-28 3:54 ` Randy.Dunlap
2004-09-28 15:05 ` Jeff Garzik
2004-09-28 17:13 ` Ravinandan Arakali
2004-10-06 20:14 ` Ravinandan Arakali
2004-10-06 20:09 ` Jeff Garzik
2004-10-06 20:20 ` Francois Romieu
2004-10-06 22:52 ` Jeff Garzik
2004-10-07 1:04 ` [PATCH 2.6.9-rc2 1/8] S2io: cosmetic changes Ravinandan Arakali
2004-09-17 3:58 ` Randy.Dunlap [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-13 22:45 Patch submission for S2io Xframe driver to 2.6 kernel Ravinandan Arakali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916205849.55ce05e5.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=jgarzik@pobox.com \
--cc=leonid.grossman@s2io.com \
--cc=netdev@oss.sgi.com \
--cc=raghavendra.koushik@s2io.com \
--cc=rapuru.sriram@s2io.com \
--cc=ravinandan.arakali@s2io.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).