* crash in fib_hash_move
@ 2004-09-17 18:42 Stephen Hemminger
2004-09-17 18:47 ` Krishna Kumar
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stephen Hemminger @ 2004-09-17 18:42 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Current 2.6 tree is crashing on bootup in fib code.
Looks like recent FIB changes problem.
--------------
Unable to handle kernel paging request at virtual address 00003232
printing eip:
*pde = 00000000
Oops: 0002 [#1]
PREEMPT SMP
Modules linked in: ext3 jbd DAC960 aic7xxx sd_mod scsi_mod
CPU: 5
EIP: 0060:[<c0278f14>] Not tainted VLI
EFLAGS: 00010206 (2.6.9-rc2)
EIP is at fib_hash_move+0x90/0x146
eax: 0000322e ebx: c316b480 ecx: 00000004 edx: f6cc5630
esi: c316b380 edi: f6cc5620 ebp: 00000000 esp: f6e0cd94
ds: 007b es: 007b ss: 0068
Process ifconfig (pid: 1507, threadinfo=f6e0c000 task=f6db0550)
Stack: 00000000 00000004 f6cc82e0 00000008 f6cc82e0 00000020 f6cc5620 c0279062
00000020 00000001 00000000 ffffff97 f6e0ce40 f6e0ce90 ffffffea f6e0ce40
c314a980 f6cc6ec0 c027a8cd f6e0ce14 f6e0ce80 00000000 03ccf180 ffff14ac
Call Trace:
[<c0279062>] fib_create_info+0x98/0x529
[<c027a8cd>] fn_hash_insert+0xab/0x4d1
[<c0278242>] fib_magic+0x104/0x129
[<c02782f1>] fib_add_ifaddr+0x8a/0x12b
[<c02785a7>] fib_inetaddr_event+0x47/0x53
[<c0124da2>] notifier_call_chain+0x17/0x2b
[<c02710a2>] inet_insert_ifa+0x8e/0x12b
[<c0271950>] devinet_ioctl+0x317/0x60e
[<c02738cb>] inet_ioctl+0x5b/0x8f
[<c0230051>] sock_ioctl+0xdb/0x25b
[<c014c55f>] fget+0x49/0x5e
[<c015ba1c>] sys_ioctl+0xf5/0x24d
[<c0105871>] sysenter_past_esp+0x52/0x71
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: crash in fib_hash_move
2004-09-17 18:42 crash in fib_hash_move Stephen Hemminger
@ 2004-09-17 18:47 ` Krishna Kumar
2004-09-17 18:51 ` Jeff Garzik
2004-09-17 19:36 ` David S. Miller
2 siblings, 0 replies; 4+ messages in thread
From: Krishna Kumar @ 2004-09-17 18:47 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David S. Miller, netdev
[-- Attachment #1.1: Type: text/plain, Size: 2741 bytes --]
Probably the same problem checked in today by DM. See "Re: [TRIVIAL] Fix
recent bug in fib_semantics.c".
- KK
Stephen Hemminger
<shemminger@osdl.
org> To
Sent by: "David S. Miller"
netdev-bounce@oss <davem@redhat.com>
.sgi.com cc
netdev@oss.sgi.com
Subject
09/17/2004 11:42 crash in fib_hash_move
AM
Current 2.6 tree is crashing on bootup in fib code.
Looks like recent FIB changes problem.
--------------
Unable to handle kernel paging request at virtual address 00003232
printing eip:
*pde = 00000000
Oops: 0002 [#1]
PREEMPT SMP
Modules linked in: ext3 jbd DAC960 aic7xxx sd_mod scsi_mod
CPU: 5
EIP: 0060:[<c0278f14>] Not tainted VLI
EFLAGS: 00010206 (2.6.9-rc2)
EIP is at fib_hash_move+0x90/0x146
eax: 0000322e ebx: c316b480 ecx: 00000004 edx: f6cc5630
esi: c316b380 edi: f6cc5620 ebp: 00000000 esp: f6e0cd94
ds: 007b es: 007b ss: 0068
Process ifconfig (pid: 1507, threadinfo=f6e0c000 task=f6db0550)
Stack: 00000000 00000004 f6cc82e0 00000008 f6cc82e0 00000020 f6cc5620
c0279062
00000020 00000001 00000000 ffffff97 f6e0ce40 f6e0ce90 ffffffea
f6e0ce40
c314a980 f6cc6ec0 c027a8cd f6e0ce14 f6e0ce80 00000000 03ccf180
ffff14ac
Call Trace:
[<c0279062>] fib_create_info+0x98/0x529
[<c027a8cd>] fn_hash_insert+0xab/0x4d1
[<c0278242>] fib_magic+0x104/0x129
[<c02782f1>] fib_add_ifaddr+0x8a/0x12b
[<c02785a7>] fib_inetaddr_event+0x47/0x53
[<c0124da2>] notifier_call_chain+0x17/0x2b
[<c02710a2>] inet_insert_ifa+0x8e/0x12b
[<c0271950>] devinet_ioctl+0x317/0x60e
[<c02738cb>] inet_ioctl+0x5b/0x8f
[<c0230051>] sock_ioctl+0xdb/0x25b
[<c014c55f>] fget+0x49/0x5e
[<c015ba1c>] sys_ioctl+0xf5/0x24d
[<c0105871>] sysenter_past_esp+0x52/0x71
[-- Attachment #1.2: Type: text/html, Size: 4185 bytes --]
[-- Attachment #2: graycol.gif --]
[-- Type: image/gif, Size: 105 bytes --]
[-- Attachment #3: pic00286.gif --]
[-- Type: image/gif, Size: 1255 bytes --]
[-- Attachment #4: ecblank.gif --]
[-- Type: image/gif, Size: 45 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: crash in fib_hash_move
2004-09-17 18:42 crash in fib_hash_move Stephen Hemminger
2004-09-17 18:47 ` Krishna Kumar
@ 2004-09-17 18:51 ` Jeff Garzik
2004-09-17 19:36 ` David S. Miller
2 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2004-09-17 18:51 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David S. Miller, netdev
On Fri, Sep 17, 2004 at 11:42:49AM -0700, Stephen Hemminger wrote:
> Current 2.6 tree is crashing on bootup in fib code.
> Looks like recent FIB changes problem.
Yeah, David Gibson already posted a fix, see
"[TRIVIAL] Fix recent bug in fib_semantics.c"
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: crash in fib_hash_move
2004-09-17 18:42 crash in fib_hash_move Stephen Hemminger
2004-09-17 18:47 ` Krishna Kumar
2004-09-17 18:51 ` Jeff Garzik
@ 2004-09-17 19:36 ` David S. Miller
2 siblings, 0 replies; 4+ messages in thread
From: David S. Miller @ 2004-09-17 19:36 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
On Fri, 17 Sep 2004 11:42:49 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> Current 2.6 tree is crashing on bootup in fib code.
> Looks like recent FIB changes problem.
Missing memset()'s on the newly allocated hash tables,
fixed by the following which I just pused to Linus:
Return-Path: <dgibson@ozlabs.org>
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
by devserv.devel.redhat.com (8.12.11/8.12.10) with ESMTP id i8H6XIL3028885
for <davem@devserv.devel.redhat.com>; Fri, 17 Sep 2004 02:33:18 -0400
Received: from mx1.redhat.com (mx1.redhat.com [172.16.48.31])
by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8H6XPr27780
for <davem@redhat.com>; Fri, 17 Sep 2004 02:33:25 -0400
Received: from ozlabs.org (ozlabs.org [203.10.76.45])
by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8H6XOij016918
for <davem@redhat.com>; Fri, 17 Sep 2004 02:33:24 -0400
Received: by ozlabs.org (Postfix, from userid 1007)
id B10E92BD6A; Fri, 17 Sep 2004 16:33:17 +1000 (EST)
Date: Fri, 17 Sep 2004 16:20:42 +1000
From: David Gibson <david@gibson.dropbear.id.au>
To: Andrew Morton <akpm@osdl.org>
Cc: David Miller <davem@redhat.com>, trivial@rustcorp.com.au,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: [TRIVIAL] Fix recent bug in fib_semantics.c
Message-ID: <20040917062042.GE6523@zax>
Mail-Followup-To: David Gibson <david@gibson.dropbear.id.au>,
Andrew Morton <akpm@osdl.org>, David Miller <davem@redhat.com>,
trivial@rustcorp.com.au, linux-kernel@vger.kernel.org,
netdev@oss.sgi.com
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.6+20040818i
X-RedHat-Spam-Score: 0
Status:
Andrew, please apply:
When fib_create_info() allocates new hash tables, it neglects to
initialize them. This leads to an oops during boot on at least
machine I use. This patch addresses the problem.
Signed-off-by: David Gibson <dwg@au1.ibm.com>
Index: working-2.6/net/ipv4/fib_semantics.c
===================================================================
--- working-2.6.orig/net/ipv4/fib_semantics.c 2004-09-17 09:20:04.000000000 +1000
+++ working-2.6/net/ipv4/fib_semantics.c 2004-09-17 16:24:42.634638304 +1000
@@ -604,8 +604,12 @@
if (!new_info_hash || !new_laddrhash) {
fib_hash_free(new_info_hash, bytes);
fib_hash_free(new_laddrhash, bytes);
- } else
+ } else {
+ memset(new_info_hash, 0, bytes);
+ memset(new_laddrhash, 0, bytes);
+
fib_hash_move(new_info_hash, new_laddrhash, new_size);
+ }
if (!fib_hash_size)
goto failure;
--
David Gibson | For every complex problem there is a
david AT gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-09-17 19:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-17 18:42 crash in fib_hash_move Stephen Hemminger
2004-09-17 18:47 ` Krishna Kumar
2004-09-17 18:51 ` Jeff Garzik
2004-09-17 19:36 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).