From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jonsmirl@gmail.com, david@gibson.dropbear.id.au, akpm@osdl.org,
trivial@rustcorp.com.au, linux-kernel@vger.kernel.org,
netdev@oss.sgi.com
Subject: Re: [TRIVIAL] Fix recent bug in fib_semantics.c
Date: Fri, 17 Sep 2004 23:31:08 -0700 [thread overview]
Message-ID: <20040917233108.561c88d6.davem@davemloft.net> (raw)
In-Reply-To: <20040918041627.GA12356@gondor.apana.org.au>
On Sat, 18 Sep 2004 14:16:28 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Thanks. The following bug is probably your problem.
Good catch on this fix, but really he's hitting the
BUG_ON() in fib_sync_down() (I hate i386 backtraces,
it's an art to decode them properly)
So if you rmmod() a device before any routes are ever
created in ipv4, this triggers. I didn't think this
was possible, but it is.
The fix is simple enough.
===== net/ipv4/fib_semantics.c 1.16 vs edited =====
--- 1.16/net/ipv4/fib_semantics.c 2004-09-17 11:11:04 -07:00
+++ edited/net/ipv4/fib_semantics.c 2004-09-17 23:14:44 -07:00
@@ -1040,9 +1040,7 @@
if (force)
scope = -1;
- BUG_ON(!fib_info_laddrhash);
-
- if (local) {
+ if (local && fib_info_laddrhash) {
unsigned int hash = fib_laddr_hashfn(local);
struct hlist_head *head = &fib_info_laddrhash[hash];
struct hlist_node *node;
next prev parent reply other threads:[~2004-09-18 6:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-17 6:20 [TRIVIAL] Fix recent bug in fib_semantics.c David Gibson
2004-09-17 6:37 ` Jeff Garzik
2004-09-17 18:27 ` David S. Miller
2004-09-18 0:21 ` Jon Smirl
2004-09-18 0:27 ` Herbert Xu
2004-09-18 0:59 ` Jon Smirl
2004-09-18 1:37 ` Jon Smirl
2004-09-18 4:16 ` Herbert Xu
2004-09-18 5:22 ` Jon Smirl
2004-09-18 6:31 ` David S. Miller [this message]
2004-09-18 15:28 ` Jon Smirl
2004-09-18 20:31 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040917233108.561c88d6.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=david@gibson.dropbear.id.au \
--cc=herbert@gondor.apana.org.au \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).