From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
hadi@cyberus.ca, netdev@oss.sgi.com
Subject: Re: [PATCH] Clean up fib_hash datastructures
Date: Tue, 21 Sep 2004 11:04:23 +0200 [thread overview]
Message-ID: <20040921090423.GE8058@wotan.suse.de> (raw)
In-Reply-To: <20040920231805.3f18479c.davem@davemloft.net>
On Mon, Sep 20, 2004 at 11:18:05PM -0700, David S. Miller wrote:
> On Tue, 21 Sep 2004 13:42:12 +1000
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> > On Mon, Sep 20, 2004 at 07:11:23PM +0000, David S. Miller wrote:
> > >
> > > I believe I was successful in preserving existing behavior, but
> > > I wonder if it makes sense any longer. CONFIG_IP_ROUTE_TOS
> > > changes not one data structure. It does exactly:
> >
> > Yes CONFIG_IP_ROUTE_TOS has out-lived its usefulness. It has
> > always seemed half-hearted compared to CONFIG_IP_ROUTE_FWMARK.
>
> Ok, then I'm gonna nuke it.
Hmm, are you removing TOS support completely or just remove the
CONFIG and always enable the code?
[Somehow it looks to me like you and Herbert are miscommunicating ;-]
I think you should remove the TOS support completely because
it's obsolete with fwmark. And maybe remove it will allow
some tuning later.
-Andi
next prev parent reply other threads:[~2004-09-21 9:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-19 3:33 [PATCH] Clean up fib_hash datastructures David S. Miller
2004-09-20 0:39 ` jamal
2004-09-20 2:46 ` David S. Miller
2004-09-20 3:14 ` Herbert Xu
2004-09-20 3:17 ` David S. Miller
2004-09-20 13:33 ` jamal
2004-09-20 1:51 ` jamal
2004-09-20 2:53 ` David S. Miller
2004-09-20 13:24 ` jamal
2004-09-20 19:11 ` David S. Miller
2004-09-21 3:42 ` Herbert Xu
2004-09-21 6:18 ` David S. Miller
2004-09-21 9:04 ` Andi Kleen [this message]
2004-09-21 9:32 ` Herbert Xu
2004-09-21 11:03 ` jamal
2004-09-21 12:07 ` Andi Kleen
2004-09-21 12:22 ` jamal
2004-09-21 23:38 ` Steven Blake
2004-09-22 3:10 ` jamal
2004-09-22 11:56 ` Steven Blake
2004-09-22 12:12 ` jamal
2004-09-22 20:04 ` Steven Blake
2004-09-22 2:07 ` Herbert Xu
2004-09-22 2:32 ` David S. Miller
2004-09-22 3:57 ` [IPv4] Check PAGE_SIZE in fz_hash_alloc Herbert Xu
2004-09-23 20:05 ` David S. Miller
2004-09-22 3:30 ` [PATCH] Clean up fib_hash datastructures jamal
2004-09-22 3:36 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040921090423.GE8058@wotan.suse.de \
--to=ak@suse.de \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).