From: Thomas Graf <tgraf@suug.ch>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6 NET] Fix ifmap alignment issues over rtnetlink
Date: Wed, 22 Sep 2004 02:03:25 +0200 [thread overview]
Message-ID: <20040922000325.GN566@postel.suug.ch> (raw)
In-Reply-To: <20040921165733.3e0d31d8.davem@davemloft.net>
* David S. Miller <20040921165733.3e0d31d8.davem@davemloft.net> 2004-09-21 16:57
> On Wed, 22 Sep 2004 00:41:27 +0200
> Thomas Graf <tgraf@suug.ch> wrote:
>
> > + k_map.mem_start = (unsigned long) u_map->mem_start;
> > + k_map.mem_end = (unsigned long) u_map->mem_end;
> > + k_map.base_addr = (unsigned short) u_map->base_addr;
> > + k_map.irq = (unsigned char) u_map->irq;
> > + k_map.dma = (unsigned char) u_map->dma;
> > + k_map.port = (unsigned char) u_map->port;
>
> Please cast to the actual types that struct ifmap uses,
> otherwise the change is OK.
It is or am I missing something?
next prev parent reply other threads:[~2004-09-22 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-21 22:41 [PATCH 2.6 NET] Fix ifmap alignment issues over rtnetlink Thomas Graf
2004-09-21 23:57 ` David S. Miller
2004-09-22 0:03 ` Thomas Graf [this message]
2004-09-22 0:21 ` David S. Miller
2004-09-22 2:18 ` Herbert Xu
2004-09-22 2:36 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040922000325.GN566@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).