netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [PATCH 1/2 2.6] e100: fix NAPI race with watchdog
Date: Wed, 22 Sep 2004 13:38:23 -0700	[thread overview]
Message-ID: <20040922133823.50a66ef9@dell_ss3.pdx.osdl.net> (raw)
In-Reply-To: <Pine.LNX.4.44.0409221217010.7544-100000@isotope.jf.intel.com>

On Wed, 22 Sep 2004 12:25:44 -0700 (PDT)
Jesse Brandeburg <jesse.brandeburg@intel.com> wrote:

> While polling in NAPI mode, we were occassionally getting interrupts 
> re-enabled by the watchdog trying to generate a software interrupt.  Fix 
> is to add a spinlock around that shared hardware register to allow a 
> read-modify-write operation.  This was nasty nasty.  I don't like the 
> spinlock in the hot path but i see no other way.  Comments are welcome.
> Updates the driver version as well.

You could convert it to LLTX then at least there is only one lock roundtrip

  reply	other threads:[~2004-09-22 20:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-22 19:25 [PATCH 1/2 2.6] e100: fix NAPI race with watchdog Jesse Brandeburg
2004-09-22 20:38 ` Stephen Hemminger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-09-23  9:08 James Chapman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040922133823.50a66ef9@dell_ss3.pdx.osdl.net \
    --to=shemminger@osdl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).