* [IPv4] Missing TOS checks after fib_find_alias
@ 2004-09-23 6:28 Herbert Xu
2004-09-23 20:38 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Herbert Xu @ 2004-09-23 6:28 UTC (permalink / raw)
To: David S. Miller, netdev
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
Hi Dave:
It looks like some of the places where FIB_SCAN_TOS macros were used
have lost the tos check. This patch adds them back.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 643 bytes --]
===== net/ipv4/fib_hash.c 1.24 vs edited =====
--- 1.24/net/ipv4/fib_hash.c 2004-09-23 16:10:05 +10:00
+++ edited/net/ipv4/fib_hash.c 2004-09-23 16:16:48 +10:00
@@ -538,6 +538,8 @@
*/
fa_orig = fa;
list_for_each_entry(fa, fa_orig->fa_list.prev, fa_list) {
+ if (fa->fa_tos != tos)
+ break;
if (fa->fa_info->fib_priority != fi->fib_priority)
break;
if (fa->fa_type == type &&
@@ -636,6 +638,9 @@
fa_to_delete = NULL;
list_for_each_entry(fa, fa->fa_list.prev, fa_list) {
struct fib_info *fi = fa->fa_info;
+
+ if (fa->fa_tos != tos)
+ break;
if ((!r->rtm_type ||
fa->fa_type == r->rtm_type) &&
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [IPv4] Missing TOS checks after fib_find_alias
2004-09-23 6:28 [IPv4] Missing TOS checks after fib_find_alias Herbert Xu
@ 2004-09-23 20:38 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-09-23 20:38 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev
On Thu, 23 Sep 2004 16:28:31 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> It looks like some of the places where FIB_SCAN_TOS macros were used
> have lost the tos check. This patch adds them back.
Right you are, patch applied.
Thanks Herbert.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-23 20:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-23 6:28 [IPv4] Missing TOS checks after fib_find_alias Herbert Xu
2004-09-23 20:38 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).