From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Margit Schubert-While <margitsw@t-online.de>
Cc: davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: msleep changes
Date: Thu, 23 Sep 2004 09:08:10 -0700 [thread overview]
Message-ID: <20040923160810.GC1699@us.ibm.com> (raw)
In-Reply-To: <5.1.0.14.2.20040923050120.0257f490@pop.t-online.de>
On Thu, Sep 23, 2004 at 05:24:33AM +0200, Margit Schubert-While wrote:
> Hi Nish,
> In latest BK :
>
> # drivers/atm/lanai.c
> # 2004/09/21 14:58:17-07:00 chas@cmf.nrl.navy.mil +1 -1
> # [ATM]: [drivers] Use msleep() instead of schedule_timeout()
> # From Nishanth Aravamudan <nacc@us.ibm.com>
>
> diff -Nru a/drivers/atm/lanai.c b/drivers/atm/lanai.c
> --- a/drivers/atm/lanai.c 2004-09-21 17:11:30 -07:00
> +++ b/drivers/atm/lanai.c 2004-09-21 17:11:30 -07:00
> @@ -813,7 +813,7 @@
> DPRINTK("read, write = %d, %d\n", read, write);
> break;
> }
> - schedule_timeout(HZ / 25);
> + msleep(4);
>
>
> ??????
>
> Just one that immediately lept to my eye.
> I am not going to check them all.
> That's your job :-)
Thanks for catching this. I actually have re-pushed the patch already
with the correct time, but it is only going to be in the latest kjt
(which was sent yesterday, I think). Ahh, I see the problem; somehow the
maintainer's patch had msleep(4) in it, even though my patch had
msleep(40). It should be corrected soon. Thanks for seeing this, again.
-Nish
prev parent reply other threads:[~2004-09-23 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 3:24 msleep changes Margit Schubert-While
2004-09-23 16:08 ` Nishanth Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040923160810.GC1699@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=davem@davemloft.net \
--cc=margitsw@t-online.de \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).