* Re: msleep changes
@ 2004-09-23 3:24 Margit Schubert-While
2004-09-23 16:08 ` Nishanth Aravamudan
0 siblings, 1 reply; 2+ messages in thread
From: Margit Schubert-While @ 2004-09-23 3:24 UTC (permalink / raw)
To: Nishanth Aravamudan; +Cc: davem, netdev
Hi Nish,
In latest BK :
# drivers/atm/lanai.c
# 2004/09/21 14:58:17-07:00 chas@cmf.nrl.navy.mil +1 -1
# [ATM]: [drivers] Use msleep() instead of schedule_timeout()
# From Nishanth Aravamudan <nacc@us.ibm.com>
diff -Nru a/drivers/atm/lanai.c b/drivers/atm/lanai.c
--- a/drivers/atm/lanai.c 2004-09-21 17:11:30 -07:00
+++ b/drivers/atm/lanai.c 2004-09-21 17:11:30 -07:00
@@ -813,7 +813,7 @@
DPRINTK("read, write = %d, %d\n", read, write);
break;
}
- schedule_timeout(HZ / 25);
+ msleep(4);
??????
Just one that immediately lept to my eye.
I am not going to check them all.
That's your job :-)
These msleep(_interruptible) changes have been tested or ?
Margit
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: msleep changes
2004-09-23 3:24 msleep changes Margit Schubert-While
@ 2004-09-23 16:08 ` Nishanth Aravamudan
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-09-23 16:08 UTC (permalink / raw)
To: Margit Schubert-While; +Cc: davem, netdev
On Thu, Sep 23, 2004 at 05:24:33AM +0200, Margit Schubert-While wrote:
> Hi Nish,
> In latest BK :
>
> # drivers/atm/lanai.c
> # 2004/09/21 14:58:17-07:00 chas@cmf.nrl.navy.mil +1 -1
> # [ATM]: [drivers] Use msleep() instead of schedule_timeout()
> # From Nishanth Aravamudan <nacc@us.ibm.com>
>
> diff -Nru a/drivers/atm/lanai.c b/drivers/atm/lanai.c
> --- a/drivers/atm/lanai.c 2004-09-21 17:11:30 -07:00
> +++ b/drivers/atm/lanai.c 2004-09-21 17:11:30 -07:00
> @@ -813,7 +813,7 @@
> DPRINTK("read, write = %d, %d\n", read, write);
> break;
> }
> - schedule_timeout(HZ / 25);
> + msleep(4);
>
>
> ??????
>
> Just one that immediately lept to my eye.
> I am not going to check them all.
> That's your job :-)
Thanks for catching this. I actually have re-pushed the patch already
with the correct time, but it is only going to be in the latest kjt
(which was sent yesterday, I think). Ahh, I see the problem; somehow the
maintainer's patch had msleep(4) in it, even though my patch had
msleep(40). It should be corrected soon. Thanks for seeing this, again.
-Nish
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-23 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-23 3:24 msleep changes Margit Schubert-While
2004-09-23 16:08 ` Nishanth Aravamudan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).