From: Thomas Graf <tgraf@suug.ch>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: [PATCH 2.6 PKT_SCHED] Report qdisc parent to userspace
Date: Fri, 24 Sep 2004 14:37:10 +0200 [thread overview]
Message-ID: <20040924123710.GB3944@postel.suug.ch> (raw)
Report parent classid of a qdisc back to userspace. Without this there
is no way for userspace to see if the qdisc is attached to a class
other than parsing all class trees of the link and check all tcm_info
fields in the leaf classes.
Note: This has nothing to do with __parent.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
--- linux-2.6.9-rc2-bk7.orig/include/net/pkt_sched.h 2004-09-21 23:26:54.000000000 +0200
+++ linux-2.6.9-rc2-bk7/include/net/pkt_sched.h 2004-09-24 14:15:36.000000000 +0200
@@ -80,6 +80,7 @@
int padded;
struct Qdisc_ops *ops;
u32 handle;
+ u32 parent;
atomic_t refcnt;
struct sk_buff_head q;
struct net_device *dev;
--- linux-2.6.9-rc2-bk7.orig/net/sched/sch_api.c 2004-09-21 23:27:31.000000000 +0200
+++ linux-2.6.9-rc2-bk7/net/sched/sch_api.c 2004-09-24 13:56:03.000000000 +0200
@@ -702,10 +702,11 @@
return -ENOENT;
if (clid == TC_H_INGRESS)
q = qdisc_create(dev, tcm->tcm_parent, tca, &err);
- else
+ else
q = qdisc_create(dev, tcm->tcm_handle, tca, &err);
if (q == NULL)
return err;
+ q->parent = clid;
graft:
if (1) {
@@ -821,7 +822,7 @@
q_idx++;
continue;
}
- if (tc_fill_qdisc(skb, q, 0, NETLINK_CB(cb->skb).pid,
+ if (tc_fill_qdisc(skb, q, q->parent, NETLINK_CB(cb->skb).pid,
cb->nlh->nlmsg_seq, NLM_F_MULTI, RTM_NEWQDISC) <= 0) {
read_unlock_bh(&qdisc_tree_lock);
goto done;
next reply other threads:[~2004-09-24 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-24 12:37 Thomas Graf [this message]
2004-09-24 12:52 ` [PATCH 2.6 PKT_SCHED] Report qdisc parent to userspace Thomas Graf
2004-09-24 14:00 ` [RESEND PATCH " Thomas Graf
2004-09-28 21:19 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040924123710.GB3944@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).