From: maximilian attems <janitor@sternwelten.at>
To: Margit Schubert-While <margitsw@t-online.de>
Cc: Nishanth Aravamudan <nacc@us.ibm.com>,
netdev@oss.sgi.com, mcgrof@studorgs.rutgers.edu,
kernel-janitors@lists.osdl.org, jgarzik@pobox.com,
prism54-devel@prism54.org, hvr@gnu.org
Subject: Re: [Kernel-janitors] [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace schedule_timeout() with msleep()
Date: Fri, 24 Sep 2004 18:34:00 +0200 [thread overview]
Message-ID: <20040924163400.GA3118@stro.at> (raw)
In-Reply-To: <5.1.0.14.2.20040924074745.00b1cd40@pop.t-online.de>
On Fri, 24 Sep 2004, Margit Schubert-While wrote:
..
> The patch has wrong line numbers. Doesn't take into account the stacked up
> netdev changes. (Therefore CC'ing Jeff Garzik)
sure the kj patches are against mainline.
> This breaks 2.4 compatibility.
> So either backport to 2.4 or Nish can take over prism54 2.4 maintenance ;-)
can't remember the last time when Randy submitted janitorial patches to
2.4.x, but it's long ago. 2.4 is in maintenance mode.
> Don't say a backport is not possible/reasonable, it happened with
> netdev_priv().
> (In 2.4.27; At least there, we have HAVE_NETDEV_PRIV).
there must have been serious reasons for that.
> If this is going to be forced, can we at least have a
> define HAVE_MSLEEP in delay.h ?
>
> I am somewhat confused by the second part of the patch.
> What has that got to do with msleep ?
basically a lot, because as prism54 lots of drivers forgo/et to set
there state when calling schedule_timeout().
> Actually, the fix would appear to be correct, but that is a seperate issue
> and nothing to do with msleep.
> (Prims54 developers -> I'll take a look over the weekend)
great, please also remove the unused TRACE macro.
(patch was sent to netdev on 3. Sept).
the kj mailing list got another submission to correct
the __FUNCTION__ use their. :)
> I am sceptical about the whole msleep patchset as, by their own admission,
> the janitors have/can not (no hardware) test the majority of the changes.
> Even more worrying is that incorrect code has directly appeared in
> mainline kernel BK.
the named small errors were quickly corrected.
it's up to the driver MAINTAINER to prove us wrong.
we got lots of ack in between.
--
maks
kernel janitor http://janitor.kernelnewbies.org/
next prev parent reply other threads:[~2004-09-24 16:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040923221303.GB13244@us.ibm.com>
2004-09-23 22:55 ` [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace schedule_timeout() with msleep() Luis R. Rodriguez
2004-09-24 7:43 ` Margit Schubert-While
2004-09-24 16:34 ` maximilian attems [this message]
2004-10-01 4:15 ` Jeff Garzik
2004-10-01 7:04 ` Margit Schubert-While
2004-10-01 16:55 ` [Kernel-janitors] " Greg KH
2004-10-02 9:07 ` Margit Schubert-While
2004-10-04 21:04 ` Jeff Garzik
2004-10-30 22:22 ` [KJ] [patch 2.4] back port msleep(), msleep_interruptible() maximilian attems
2004-10-30 22:41 ` Jeff Garzik
2004-10-30 22:59 ` [KJ] " Nish Aravamudan
2004-10-30 22:59 ` Nish Aravamudan
[not found] ` <29495f1d041030155953a9a776@mail.gmail.com>
2004-10-30 23:19 ` maximilian attems
2004-10-30 23:19 ` maximilian attems
2004-10-31 14:43 ` maximilian attems
2004-10-31 14:43 ` maximilian attems
2004-10-31 14:44 ` [KJ] [patch 1/6] " maximilian attems
2004-10-31 14:44 ` [patch 2/6] libata remove duplicate definition msecs_to_jiffies() maximilian attems
2004-10-31 14:44 ` [patch 3/6] sx8 remove duplicate definition msleep(), msecs_to_jiffies() maximilian attems
2004-10-31 14:45 ` [patch 4/6] char/shwdt remove duplicate msecs_to_jiffies() maximilian attems
2004-10-31 14:45 ` [patch 5/6] sata_promise remove duplicate msleep() definition maximilian attems
2004-10-31 14:45 ` [patch 6/6] libata remove msleep_libata() maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040924163400.GA3118@stro.at \
--to=janitor@sternwelten.at \
--cc=hvr@gnu.org \
--cc=jgarzik@pobox.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=margitsw@t-online.de \
--cc=mcgrof@studorgs.rutgers.edu \
--cc=nacc@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=prism54-devel@prism54.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).