From: "David S. Miller" <davem@davemloft.net>
To: Harald Welte <laforge@gnumonks.org>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] neighbour cache statistics like rt_stat
Date: Mon, 27 Sep 2004 12:21:36 -0700 [thread overview]
Message-ID: <20040927122136.7016b2c1.davem@davemloft.net> (raw)
In-Reply-To: <20040927162334.GV3236@sunbeam.de.gnumonks.org>
On Mon, 27 Sep 2004 18:23:34 +0200
Harald Welte <laforge@gnumonks.org> wrote:
> On Mon, Sep 27, 2004 at 11:36:13AM +0200, Harald Welte wrote:
> > The patch below (on top of davem's recent 6-patch set and 4-patch-set up
> > to diff4) adds rt_stat like statistics to the neighbour cache core.
>
> I've now updated the patch.
>
> Changes:
> - more statistics (lookups, destroy, periodic_gc_runs)
> - add template line to top of file
I'm generally very happy with these changes, but two things:
1) Please update the patch since I replaced "diff4" with
a patch simply removing the INCOMPLETE checks from neigh_forced_gc()
2) I'd recommend using unsigned long for all the statistics.
Thanks.
next prev parent reply other threads:[~2004-09-27 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 9:36 [PATCH 2.6] neighbour cache statistics like rt_stat Harald Welte
2004-09-27 16:23 ` Harald Welte
2004-09-27 19:21 ` David S. Miller [this message]
2004-09-27 22:20 ` Harald Welte
2004-09-28 5:17 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040927122136.7016b2c1.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=laforge@gnumonks.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).