From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [TCP] Fixed mss in tcp_init_cwnd Date: Mon, 27 Sep 2004 16:04:54 -0700 Sender: netdev-bounce@oss.sgi.com Message-ID: <20040927160454.67cd1e11.davem@davemloft.net> References: <20040927080828.GA12056@gondor.apana.org.au> <20040927120031.55fb4a49.davem@davemloft.net> <20040927220240.GA7633@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@oss.sgi.com Return-path: To: Herbert Xu In-Reply-To: <20040927220240.GA7633@gondor.apana.org.au> Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Tue, 28 Sep 2004 08:02:40 +1000 Herbert Xu wrote: > On Mon, Sep 27, 2004 at 12:00:31PM -0700, David S. Miller wrote: > > On Mon, 27 Sep 2004 18:08:28 +1000 > > Herbert Xu wrote: > > > > > The MSS in tcp_init_cwnd should be the real one instead of the TSO value. > > > > This happens too early in the connections lifetime > > to make a difference for anything. > > I know. That's why I put it in a different thread. > > IMHO we should still fix it though at least for consistency. That early on in the connection, it should be setting both values, right? If so your patch still needs a tweak. :)