netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [NETLINK] Kill export of netlink_broadcast_deliver
@ 2004-09-28  3:47 Herbert Xu
  2004-09-28  5:28 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Herbert Xu @ 2004-09-28  3:47 UTC (permalink / raw)
  To: David S. Miller, netdev

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Hi Dave:

netlink_broadcast_deliver is marked as static as well as exported.
It certainly isn't doing anything that should be needed by any
netlink modules.  There aren't any in-kernel users either.

So let's remove the bogus export.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: p --]
[-- Type: text/plain, Size: 425 bytes --]

===== net/netlink/af_netlink.c 1.53 vs edited =====
--- 1.53/net/netlink/af_netlink.c	2004-09-22 12:32:44 +10:00
+++ edited/net/netlink/af_netlink.c	2004-09-28 13:45:28 +10:00
@@ -1220,7 +1220,6 @@
 
 EXPORT_SYMBOL(netlink_ack);
 EXPORT_SYMBOL(netlink_broadcast);
-EXPORT_SYMBOL(netlink_broadcast_deliver);
 EXPORT_SYMBOL(netlink_dump_start);
 EXPORT_SYMBOL(netlink_kernel_create);
 EXPORT_SYMBOL(netlink_register_notifier);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [NETLINK] Kill export of netlink_broadcast_deliver
  2004-09-28  3:47 [NETLINK] Kill export of netlink_broadcast_deliver Herbert Xu
@ 2004-09-28  5:28 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-09-28  5:28 UTC (permalink / raw)
  To: Herbert Xu; +Cc: netdev

On Tue, 28 Sep 2004 13:47:36 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> netlink_broadcast_deliver is marked as static as well as exported.
> It certainly isn't doing anything that should be needed by any
> netlink modules.  There aren't any in-kernel users either.
> 
> So let's remove the bogus export.

Applied, thanks Herbert.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-09-28  5:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-28  3:47 [NETLINK] Kill export of netlink_broadcast_deliver Herbert Xu
2004-09-28  5:28 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).