From: "David S. Miller" <davem@davemloft.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: hadi@cyberus.ca, netdev@oss.sgi.com
Subject: Re: RFC/PATCH capture qdisc requeue event in stats
Date: Tue, 28 Sep 2004 17:03:15 -0700 [thread overview]
Message-ID: <20040928170315.760b9851.davem@davemloft.net> (raw)
In-Reply-To: <1096416101.27967.10.camel@localhost.localdomain>
On Tue, 28 Sep 2004 17:01:41 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> On Tue, 2004-09-28 at 16:18 -0700, David S. Miller wrote:
> > On Tue, 28 Sep 2004 16:10:09 -0700
> > Stephen Hemminger <shemminger@osdl.org> wrote:
> >
> > > On Sun, 2004-08-29 at 13:13 -0400, jamal wrote:
> > > >
> > > > The requeue event is useful in finding out when a device is overloaded
> > > > on the egress (bus or bandwidth).
> > > > Atached patch introduces this. I would have used the overlimit bits
> > > > but at the moment thats being used for different semantical reasons.
> > > > I have not done extensive testing on it.
> > > >
> > > > Opinions welcome - If all is good, Dave please apply.
> > >
> > > Dave, what happened to this? I put the stuff into iproute2 but the
> > > requeue stat never made it into 2.6. Is it a bad idea?
> >
> > Yes, API breaker.
>
> Well it seems to work for me:
> kernel
> New Old
> tc New Ok Ok(0)
> Old Ok(0) Ok
>
> Because tc correctly handles the returned TLV size.
Because tc has all the length checking stuff added to
it, other applications using netlink might not. The
whole world is not 'tc'.
I'm just rehashing how the most recent thread between
Jamal and myself ended about this topic.
next prev parent reply other threads:[~2004-09-29 0:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-29 17:13 RFC/PATCH capture qdisc requeue event in stats jamal
2004-08-30 21:40 ` David S. Miller
2004-08-30 22:14 ` jamal
2004-08-30 22:44 ` David S. Miller
2004-08-30 22:56 ` jamal
2004-08-30 23:00 ` David S. Miller
2004-08-31 1:43 ` jamal
2004-08-31 2:17 ` David S. Miller
2004-08-31 2:37 ` jamal
2004-08-31 4:29 ` David S. Miller
2004-08-31 18:09 ` jamal
2004-09-29 0:36 ` Thomas Graf
2004-09-29 2:54 ` jamal
2004-09-29 12:48 ` Thomas Graf
2004-09-29 14:08 ` jamal
2004-08-30 23:05 ` Stephen Hemminger
2004-09-28 23:10 ` Stephen Hemminger
2004-09-28 23:18 ` David S. Miller
2004-09-29 0:01 ` Stephen Hemminger
2004-09-29 0:03 ` David S. Miller [this message]
2004-09-29 2:31 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040928170315.760b9851.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).