From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Graf <tgraf@suug.ch>
Subject: Re: RFC/PATCH capture qdisc requeue event in stats
Date: Wed, 29 Sep 2004 02:36:56 +0200
Sender: netdev-bounce@oss.sgi.com
Message-ID: <20040929003656.GX31616@rei.reeler.org>
References: <1093799632.1073.410.camel@jzny.localdomain> <20040830144033.2265a6e6.davem@redhat.com> <1093904088.1043.12.camel@jzny.localdomain> <20040830154430.769d1d59.davem@redhat.com> <1093906592.1037.32.camel@jzny.localdomain> <20040830160052.548c4846.davem@redhat.com> <1093916592.1037.51.camel@jzny.localdomain> <20040830191716.0d002f91.davem@redhat.com> <1093919823.1043.80.camel@jzny.localdomain> <20040830212910.78047bcd.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: hadi@cyberus.ca, netdev@oss.sgi.com, shemminger@osdl.org
Return-path: <netdev-bounce@oss.sgi.com>
To: "David S. Miller" <davem@davemloft.net>
Content-Disposition: inline
In-Reply-To: <20040830212910.78047bcd.davem@davemloft.net>
Errors-to: netdev-bounce@oss.sgi.com
List-Id: netdev.vger.kernel.org

* David S. Miller <20040830212910.78047bcd.davem@davemloft.net> 2004-08-30 21:29
> Look, let's get real about this topic.  We can't be breaking shit
> like this all the time.  We're nearly letting it happen a lot
> lately.
> 
> These data structures are user visible APIs, they are just like
> system call data structures, and if we cannot modify
> them without potentially breaking some existing application we
> cannot make that change.

Why not do it by using nested TLVs?:

  TCA_STATS2 [
      TCA_STAT_BYTES
      TCA_STAT_PACKETS
      TCA_STAT_DROPS
      ...
  ]

This way we can add as many new stats as we want without
even thinking about backward compatibility in the future.
This would also allow to implement dynamic size statistics
or introduce TCA_STAT_*_64 if ever needed.