From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <ak@suse.de>
Subject: Re: bad TSO performance in 2.6.9-rc2-BK
Date: Wed, 29 Sep 2004 01:55:34 +0200
Sender: netdev-bounce@oss.sgi.com
Message-ID: <20040929015534.3b39b720.ak@suse.de>
References: <20040923164149.5368d291.davem@davemloft.net>
	<E1CBkIW-0001dF-00@gondolin.me.apana.org.au>
	<20040927025048.GA6723@gondor.apana.org.au>
	<20040926210029.22750d47.davem@davemloft.net>
	<20040927054541.GA8858@gondor.apana.org.au>
	<20040927120154.09fdcadf.davem@davemloft.net>
	<20040927213233.GC7243@gondor.apana.org.au>
	<20040928141002.164c60af.davem@davemloft.net>
	<20040928213415.GA4646@wotan.suse.de>
	<20040928145345.2530d30e.davem@davemloft.net>
	<20040928223344.GC2975@wotan.suse.de>
	<20040928155706.65405e88.davem@davemloft.net>
	<20040929012757.5d0dff61.ak@suse.de>
	<20040928163509.624a748b.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: herbert@gondor.apana.org.au, niv@us.ibm.com, andy.grover@gmail.com,
        anton@samba.org, netdev@oss.sgi.com
Return-path: <netdev-bounce@oss.sgi.com>
To: "David S. Miller" <davem@davemloft.net>
In-Reply-To: <20040928163509.624a748b.davem@davemloft.net>
Errors-to: netdev-bounce@oss.sgi.com
List-Id: netdev.vger.kernel.org

On Tue, 28 Sep 2004 16:35:09 -0700
"David S. Miller" <davem@davemloft.net> wrote:

> On Wed, 29 Sep 2004 01:27:57 +0200
> Andi Kleen <ak@suse.de> wrote:
> 
> > I tried to re-test it but I didn't get very far because the kernel
> > with your patch crashes regularly during netperf. No serial console,
> > but the backtrace is {tcp_ack+877} {tcp_rcv_established+350} ... 
> > Before that there are a few "retrans out leaked" messages.
> 
> You might be missing the topmost part of the backtrace which is probably
> in tcp_clean_rtx_queue() or even more likely tcp_tso_acked() where there
> are several assertions present.
> 
> I guess your compiler is auto-inlining those functions for you,
> can you reproduce the crash with perhaps the noinline attribute
> added to those two functions I mention above so we can get a
> precise backtrace?

Hmpf, it stopped crashing after I recompiled without -funit-at-a-time
Maybe it is some compiler issue.

-Andi