[PATCH]: fixed typo of reassembly.c

[PATCH]: fixed typo of reassembly.c

[Yasuyuki Kozakai]

Hi,

This patch fixes byte ordering. Please apply this.

Signed-off-by: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>

Regards,

diff -X dontdiff -Nurp linux-2.6.9-rc3/net/ipv6/reassembly.c linux-2.6.9-rc3-fixed/net/ipv6/reassembly.c
--- linux-2.6.9-rc3/net/ipv6/reassembly.c	2004-09-30 18:45:24.014851224 +0900
+++ linux-2.6.9-rc3-fixed/net/ipv6/reassembly.c	2004-09-30 18:51:58.019953344 +0900
@@ -665,7 +665,7 @@ static int ip6_frag_reasm(struct frag_qu
 	head->next = NULL;
 	head->dev = dev;
 	head->stamp = fq->stamp;
-	head->nh.ipv6h->payload_len = ntohs(payload_len);
+	head->nh.ipv6h->payload_len = htons(payload_len);
 
 	*skb_in = head;
 
-----------------------------------------------------------------
Yasuyuki KOZAKAI @ USAGI Project <yasuyuki.kozakai@toshiba.co.jp>

Re: [PATCH]: fixed typo of reassembly.c

[David S. Miller]

On Thu, 30 Sep 2004 19:23:26 +0900 (JST)
Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp> wrote:

> This patch fixes byte ordering. Please apply this.

It is textual fix only, do you realize this?
Both ntohs() and htons() perform the same transformation
on a 16-bit data item.  It really does not matter which
one you actually use, in practice.

I will apply your patch anyways, I just wanted to be
clear that this does not actually fix any bug. :-)

THanks.

Re: [PATCH]: fixed typo of reassembly.c

[Herbert Xu]

David S. Miller <davem@davemloft.net> wrote:
> 
> It is textual fix only, do you realize this?
> Both ntohs() and htons() perform the same transformation
> on a 16-bit data item.  It really does not matter which
> one you actually use, in practice.

It might make a difference in future if the sparse people decide to
annotate its arguments/return values.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH]: fixed typo of reassembly.c

[David S. Miller]

On Sat, 02 Oct 2004 15:02:22 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> David S. Miller <davem@davemloft.net> wrote:
> > 
> > It is textual fix only, do you realize this?
> > Both ntohs() and htons() perform the same transformation
> > on a 16-bit data item.  It really does not matter which
> > one you actually use, in practice.
> 
> It might make a difference in future if the sparse people decide to
> annotate its arguments/return values.

That's true.  Al Viro has done this on the filesystems
and "cpu_to_{be,le}{16,32,64}()" et al. interfaces.

I'm sure he'll hit the networking before long.