From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: yasuyuki.kozakai@toshiba.co.jp, netdev@oss.sgi.com,
usagi-core@linux-ipv6.org
Subject: Re: [PATCH]: fixed typo of reassembly.c
Date: Fri, 1 Oct 2004 23:38:32 -0700 [thread overview]
Message-ID: <20041001233832.34bd0a91.davem@davemloft.net> (raw)
In-Reply-To: <E1CDc2I-0003wP-00@gondolin.me.apana.org.au>
On Sat, 02 Oct 2004 15:02:22 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> David S. Miller <davem@davemloft.net> wrote:
> >
> > It is textual fix only, do you realize this?
> > Both ntohs() and htons() perform the same transformation
> > on a 16-bit data item. It really does not matter which
> > one you actually use, in practice.
>
> It might make a difference in future if the sparse people decide to
> annotate its arguments/return values.
That's true. Al Viro has done this on the filesystems
and "cpu_to_{be,le}{16,32,64}()" et al. interfaces.
I'm sure he'll hit the networking before long.
prev parent reply other threads:[~2004-10-02 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-30 10:23 [PATCH]: fixed typo of reassembly.c Yasuyuki Kozakai
2004-10-01 22:19 ` David S. Miller
2004-10-02 5:02 ` Herbert Xu
2004-10-02 6:38 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041001233832.34bd0a91.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
--cc=usagi-core@linux-ipv6.org \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).