netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: davem@redhat.com
Cc: netdev@oss.sgi.com
Subject: [PATCH 2.6.9-rc3] dev_close: use of netif_poll_disable
Date: Sat, 2 Oct 2004 22:28:05 +0200	[thread overview]
Message-ID: <20041002202805.GA16870@electric-eye.fr.zoreil.com> (raw)

Use of identical (comment included) netif_poll_disable().

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

diff -puN net/core/dev.c~dev_close-cleanup net/core/dev.c
--- linux-2.6.9-rc3/net/core/dev.c~dev_close-cleanup	2004-10-02 22:14:29.000000000 +0200
+++ linux-2.6.9-rc3-fr/net/core/dev.c	2004-10-02 22:16:02.000000000 +0200
@@ -959,11 +959,8 @@ int dev_close(struct net_device *dev)
 	 * engine, but this requires more changes in devices. */
 
 	smp_mb__after_clear_bit(); /* Commit netif_running(). */
-	while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
-		/* No hurry. */
-		current->state = TASK_INTERRUPTIBLE;
-		schedule_timeout(1);
-	}
+
+	netif_poll_disable(dev);
 
 	/*
 	 *	Call the device specific close. This cannot fail.

_

             reply	other threads:[~2004-10-02 20:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-02 20:28 Francois Romieu [this message]
2004-10-03 22:02 ` [PATCH 2.6.9-rc3] dev_close: use of netif_poll_disable David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041002202805.GA16870@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).