netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2.6] [IPV6] SIT: dst leakage in error path.
@ 2004-10-02 10:31 YOSHIFUJI Hideaki / 吉藤英明
  2004-10-02 10:34 ` YOSHIFUJI Hideaki / 吉藤英明
  0 siblings, 1 reply; 3+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2004-10-02 10:31 UTC (permalink / raw)
  To: davem; +Cc: netdev, yoshfuji

Hello.

We failed to put rt in error path.

Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>

===== net/ipv6/sit.c 1.41 vs edited =====
--- 1.41/net/ipv6/sit.c	2004-09-17 05:10:00 +09:00
+++ edited/net/ipv6/sit.c	2004-10-02 19:24:05 +09:00
@@ -487,6 +487,7 @@
 		}
 	}
 	if (rt->rt_type != RTN_UNICAST) {
+		ip_rt_put(rt);
 		tunnel->stat.tx_carrier_errors++;
 		goto tx_error_icmp;
 	}

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2.6] [IPV6] SIT: dst leakage in error path.
  2004-10-02 10:31 [PATCH 2.6] [IPV6] SIT: dst leakage in error path YOSHIFUJI Hideaki / 吉藤英明
@ 2004-10-02 10:34 ` YOSHIFUJI Hideaki / 吉藤英明
  2004-10-03 21:57   ` David S. Miller
  0 siblings, 1 reply; 3+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2004-10-02 10:34 UTC (permalink / raw)
  To: davem; +Cc: netdev, yoshfuji

In article <20041002.193138.94763422.yoshfuji@linux-ipv6.org> (at Sat, 02 Oct 2004 19:31:38 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org> says:

> We failed to put rt in error path.
> 
> Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>

And this also applies 2.4 (with some fuzz).

--yoshfuji

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2.6] [IPV6] SIT: dst leakage in error path.
  2004-10-02 10:34 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2004-10-03 21:57   ` David S. Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2004-10-03 21:57 UTC (permalink / raw)
  To: yoshfuji; +Cc: netdev

On Sat, 02 Oct 2004 19:34:24 +0900 (JST)
YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org> wrote:

> In article <20041002.193138.94763422.yoshfuji@linux-ipv6.org> (at Sat, 02 Oct 2004 19:31:38 +0900 (JST)), YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org> says:
> 
> > We failed to put rt in error path.
> > 
> > Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> 
> And this also applies 2.4 (with some fuzz).

Applied to both trees, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-10-03 21:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-02 10:31 [PATCH 2.6] [IPV6] SIT: dst leakage in error path YOSHIFUJI Hideaki / 吉藤英明
2004-10-02 10:34 ` YOSHIFUJI Hideaki / 吉藤英明
2004-10-03 21:57   ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).