netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6.9-rc3] dev_close: use of netif_poll_disable
Date: Sun, 3 Oct 2004 15:02:29 -0700	[thread overview]
Message-ID: <20041003150229.0eb4fa67.davem@redhat.com> (raw)
In-Reply-To: <20041002202805.GA16870@electric-eye.fr.zoreil.com>

On Sat, 2 Oct 2004 22:28:05 +0200
Francois Romieu <romieu@fr.zoreil.com> wrote:

> Use of identical (comment included) netif_poll_disable().
> 
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

It's not identical.  netif_poll_disable() actually sets the
__LINK_STATE_RX_SCHED bit when it finally sees it clear.

Whereas this code in net/core/dev.c is just waiting for it
to clear.

      reply	other threads:[~2004-10-03 22:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-02 20:28 [PATCH 2.6.9-rc3] dev_close: use of netif_poll_disable Francois Romieu
2004-10-03 22:02 ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041003150229.0eb4fa67.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).