* [PATCH 2.6.9-rc3] dev_close: use of netif_poll_disable
@ 2004-10-02 20:28 Francois Romieu
2004-10-03 22:02 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Francois Romieu @ 2004-10-02 20:28 UTC (permalink / raw)
To: davem; +Cc: netdev
Use of identical (comment included) netif_poll_disable().
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
diff -puN net/core/dev.c~dev_close-cleanup net/core/dev.c
--- linux-2.6.9-rc3/net/core/dev.c~dev_close-cleanup 2004-10-02 22:14:29.000000000 +0200
+++ linux-2.6.9-rc3-fr/net/core/dev.c 2004-10-02 22:16:02.000000000 +0200
@@ -959,11 +959,8 @@ int dev_close(struct net_device *dev)
* engine, but this requires more changes in devices. */
smp_mb__after_clear_bit(); /* Commit netif_running(). */
- while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
- /* No hurry. */
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(1);
- }
+
+ netif_poll_disable(dev);
/*
* Call the device specific close. This cannot fail.
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.9-rc3] dev_close: use of netif_poll_disable
2004-10-02 20:28 [PATCH 2.6.9-rc3] dev_close: use of netif_poll_disable Francois Romieu
@ 2004-10-03 22:02 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-10-03 22:02 UTC (permalink / raw)
To: Francois Romieu; +Cc: netdev
On Sat, 2 Oct 2004 22:28:05 +0200
Francois Romieu <romieu@fr.zoreil.com> wrote:
> Use of identical (comment included) netif_poll_disable().
>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
It's not identical. netif_poll_disable() actually sets the
__LINK_STATE_RX_SCHED bit when it finally sees it clear.
Whereas this code in net/core/dev.c is just waiting for it
to clear.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-03 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-02 20:28 [PATCH 2.6.9-rc3] dev_close: use of netif_poll_disable Francois Romieu
2004-10-03 22:02 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).