netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PKT_SCHED: Remove useless line in cbq_dump_class
@ 2004-10-03 22:14 Thomas Graf
  2004-10-05 20:37 ` David S. Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Graf @ 2004-10-03 22:14 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev

Remove useless line in cbq_dump_class probably introduced by
copy&paste from cbq_dump.

Signed-off-by: Thomas Graf <tgraf@suug.ch>

--- linux-2.6.9-rc3-bk3.orig/net/sched/sch_cbq.c	2004-10-04 00:03:47.000000000 +0200
+++ linux-2.6.9-rc3-bk3/net/sched/sch_cbq.c	2004-10-04 00:07:32.000000000 +0200
@@ -1675,7 +1675,6 @@
 	cl->xstats.undertime = 0;
 	if (!PSCHED_IS_PASTPERFECT(cl->undertime))
 		cl->xstats.undertime = PSCHED_TDIFF(cl->undertime, q->now);
-	q->link.xstats.avgidle = q->link.avgidle;
 	if (cbq_copy_xstats(skb, &cl->xstats)) {
 		spin_unlock_bh(&sch->dev->queue_lock);
 		goto rtattr_failure;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PKT_SCHED: Remove useless line in cbq_dump_class
  2004-10-03 22:14 [PATCH] PKT_SCHED: Remove useless line in cbq_dump_class Thomas Graf
@ 2004-10-05 20:37 ` David S. Miller
  2004-10-05 22:23   ` Thomas Graf
  0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2004-10-05 20:37 UTC (permalink / raw)
  To: Thomas Graf; +Cc: netdev

On Mon, 4 Oct 2004 00:14:52 +0200
Thomas Graf <tgraf@suug.ch> wrote:

> Remove useless line in cbq_dump_class probably introduced by
> copy&paste from cbq_dump.
> 
> Signed-off-by: Thomas Graf <tgraf@suug.ch>

Applied to both 2.4.x and 2.6.x, thanks Thomas.

If you could check quickly whether a 2.6.x patch you post
is a relevant bug fix for 2.4.x, that would help me out
a lot in processing your patches efficiently.

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PKT_SCHED: Remove useless line in cbq_dump_class
  2004-10-05 20:37 ` David S. Miller
@ 2004-10-05 22:23   ` Thomas Graf
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Graf @ 2004-10-05 22:23 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev

* David S. Miller <20041005133754.154cf9ee.davem@davemloft.net> 2004-10-05 13:37
> If you could check quickly whether a 2.6.x patch you post
> is a relevant bug fix for 2.4.x, that would help me out
> a lot in processing your patches efficiently.

OK, didn't expect we are porting back such minor fixes but will do
so in the future.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-10-05 22:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-03 22:14 [PATCH] PKT_SCHED: Remove useless line in cbq_dump_class Thomas Graf
2004-10-05 20:37 ` David S. Miller
2004-10-05 22:23   ` Thomas Graf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).