From: "Angelo Dell'Aera" <buffer@olografix.org>
To: "David S. Miller" <davem@redhat.com>
Cc: shemminger@osdl.org, netdev@oss.sgi.com
Subject: Re: [PATCH] (1/3) tcp - choose congestion algorithm at initialization
Date: Mon, 4 Oct 2004 14:42:32 +0200 [thread overview]
Message-ID: <20041004144232.2bfa5a9e.buffer@olografix.org> (raw)
In-Reply-To: <20040927121610.68f942a4.davem@redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Mon, 27 Sep 2004 12:16:10 -0700
"David S. Miller" <davem@redhat.com> wrote:
>> The choice of congestion algorithm needs to be made when connection
>> is setup to avoid problems when the sysctl values change later and the
>> necessary data hasn't been collected.
>Looks great, applied.
I completely agree with you. Really a cool work. Just a proposal now. If
the choice is made when the connection is established we do not need a
struct for every supported congestion control algorithm in the struct
tcp_opt any more. We could use for example a generic void * and then refer
it properly after Stephen's controls such as tcp_is_vegas(), tcp_is_bic(),
etc. This should slim the struct tcp_opt because if a connection is using
Westwood its tcpbic and vegas structs will never be used. Moreover, I think
it would make the code more readable.
Regards.
- --
Angelo Dell'Aera 'buffer'
Antifork Research, Inc. http://buffer.antifork.org
Metro Olografix
PGP information in e-mail header
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFBYUU4pONIzxnBXKIRArT5AJ0Ztak7xFH9DIEd24kRxCvMMxHrBACghKmE
e0CHh6gMpJaW02Y5HVA6u78=
=av9u
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2004-10-04 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 18:18 [PATCH] (1/3) tcp - choose congestion algorithm at initialization Stephen Hemminger
2004-09-27 19:16 ` David S. Miller
2004-10-01 22:55 ` Stephen Hemminger
2004-10-03 21:52 ` David S. Miller
2004-10-04 12:42 ` Angelo Dell'Aera [this message]
2004-09-27 22:07 ` Herbert Xu
2004-09-28 5:58 ` David S. Miller
2004-09-28 16:08 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004144232.2bfa5a9e.buffer@olografix.org \
--to=buffer@olografix.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).