From: Thomas Graf <tgraf@suug.ch>
To: "David S. Miller" <davem@davemloft.net>
Cc: Jamal Hadi Salim <hadi@cyberus.ca>, netdev@oss.sgi.com
Subject: [PATCH] PKT_SCHED: Make rate estimator work for all platforms
Date: Mon, 4 Oct 2004 23:11:52 +0200 [thread overview]
Message-ID: <20041004211152.GF15898@postel.suug.ch> (raw)
Fixes the existing rate estimator to compile cleanly on all platforms
and avoids carrying on the variance on platforms with HZ%4 != 0.
Patch also applies to 2.4 with some fuzz.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
--- linux-2.6.9-rc3-bk4.orig/net/sched/estimator.c 2004-10-04 22:41:26.000000000 +0200
+++ linux-2.6.9-rc3-bk4/net/sched/estimator.c 2004-10-04 22:53:54.000000000 +0200
@@ -66,15 +66,11 @@
* Minimal interval is HZ/4=250msec (it is the greatest common divisor
for HZ=100 and HZ=1024 8)), maximal interval
- is (HZ/4)*2^EST_MAX_INTERVAL = 8sec. Shorter intervals
+ is (HZ*2^EST_MAX_INTERVAL)/4 = 8sec. Shorter intervals
are too expensive, longer ones can be implemented
at user level painlessly.
*/
-#if (HZ%4) != 0
-#error Bad HZ value.
-#endif
-
#define EST_MAX_INTERVAL 5
struct qdisc_estimator
@@ -128,7 +124,7 @@
spin_unlock(e->stats_lock);
}
- mod_timer(&elist[idx].timer, jiffies + ((HZ/4)<<idx));
+ mod_timer(&elist[idx].timer, jiffies + ((HZ<<idx)/4));
read_unlock(&est_lock);
}
@@ -161,7 +157,7 @@
if (est->next == NULL) {
init_timer(&elist[est->interval].timer);
elist[est->interval].timer.data = est->interval;
- elist[est->interval].timer.expires = jiffies + ((HZ/4)<<est->interval);
+ elist[est->interval].timer.expires = jiffies + ((HZ<<est->interval)/4);
elist[est->interval].timer.function = est_timer;
add_timer(&elist[est->interval].timer);
}
next reply other threads:[~2004-10-04 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 21:11 Thomas Graf [this message]
2004-10-04 23:47 ` [PATCH] PKT_SCHED: Make rate estimator work for all platforms jamal
2004-10-05 0:38 ` David S. Miller
2004-10-05 21:05 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004211152.GF15898@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).