From: "David S. Miller" <davem@davemloft.net>
To: Greg Banks <gnb@sgi.com>
Cc: netdev@oss.sgi.com
Subject: Re: Race between neigh_timer_handler and neigh_event_send
Date: Tue, 5 Oct 2004 11:57:25 -0700 [thread overview]
Message-ID: <20041005115725.7aa6c739.davem@davemloft.net> (raw)
In-Reply-To: <20041005101532.GA935@sgi.com>
Good catch Greg.
All of this trouble is because this is the one spot where we
make reference to the arp_queue packets without neigh->lock
held.
I wish we could avoiding dropping the lock instead, but that
is not the case. All of these ->solicit() methods can end
up calling back down into the neighbour layer and try to grab
the lock again.
I'll apply your patch, thanks.
prev parent reply other threads:[~2004-10-05 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 10:15 Race between neigh_timer_handler and neigh_event_send Greg Banks
2004-10-05 18:57 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041005115725.7aa6c739.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gnb@sgi.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).