From: Thomas Graf <tgraf@suug.ch>
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Cc: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: PATCH: [SKBUFF] introduce skb_link_header_size(skb)
Date: Tue, 5 Oct 2004 21:33:52 +0200 [thread overview]
Message-ID: <20041005193352.GA19714@rei.reeler.org> (raw)
In-Reply-To: <4162F28B.2050308@conectiva.com.br>
* Arnaldo Carvalho de Melo <4162F28B.2050308@conectiva.com.br> 2004-10-05 16:14
> +static inline int skb_link_header_size(const struct sk_buff *skb)
> +{
> + return skb->nh.raw - skb->mac.raw;
> +}
The patch is valid and I think it is right to do so but this may lead to
wrong results when skb->mac.raw is set to 0x0 F.e in classifiers. Maybe
add a comment to warn about it?
next prev parent reply other threads:[~2004-10-05 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 19:14 PATCH: [SKBUFF] introduce skb_link_header_size(skb) Arnaldo Carvalho de Melo
2004-10-05 19:33 ` Thomas Graf [this message]
2004-10-05 19:45 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041005193352.GA19714@rei.reeler.org \
--to=tgraf@suug.ch \
--cc=acme@conectiva.com.br \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).