From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Subject: Re: [PATCH 5/5] PKT_SCHED: Qdisc are not supposed to dump TCA_STATS themselves
Date: Sat, 9 Oct 2004 18:26:02 +0200 [thread overview]
Message-ID: <20041009162602.GA21977@postel.suug.ch> (raw)
In-Reply-To: <1097336911.1051.149.camel@jzny.localdomain>
> 1-4 look good.
>
> Caveat to note Dave: both old TC_STAT as well as new TC_STAT2 will be
> generated. Newer software can ignore TC_STAT and older s/ware can ignore
> TC_STAT2.
Correct, I tested all these cases and it works perfectly fine.
I also completed porting TCA_XSTATS to the new gnet_stats by
introducing dump_stats to Qdisc_ops. I ported your requeues patch
and added a missing update in SFQ qdisc. I will send those changes
once these have been approved. I will do the same for classes
and classifiers, although we will have to talk about it a little
as soon as you feel better again. I guess the classifier part will
involve changing the action code.
> patch 5 is a fix thats independent to 1-4 and should be applied
> regardless of the status of 1-4
Right, same for the cbq fix I sent a bit later which I have no clue how it is
possible that such a major bug can live for so long, I've been triggering
this bug for over 3 years and didn't notice anything until now :->
next prev parent reply other threads:[~2004-10-09 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-07 1:01 [PATCH 0/5] PKT_SCHED: Convert Qdiscs to use generic network statistics/estimator Thomas Graf
2004-10-07 1:03 ` [PATCH 1/5] PKT_SCHED: Replace tc_stats with new gnet_stats in struct Qdisc Thomas Graf
2004-10-07 1:04 ` [PATCH 2/5] PKT_SCHED: Use gnet_stats API to copy statistics into netlink message Thomas Graf
2004-10-07 1:05 ` [PATCH 3/5] PKT_SCHED: Introduce gen_replace_estimator Thomas Graf
2004-10-07 1:07 ` [PATCH 4/5] PKT_SCHED: Use generic rate estimator Thomas Graf
2004-10-07 1:08 ` [PATCH 5/5] PKT_SCHED: Qdisc are not supposed to dump TCA_STATS themselves Thomas Graf
2004-10-09 15:48 ` jamal
2004-10-09 16:26 ` Thomas Graf [this message]
2004-10-09 16:41 ` jamal
2004-10-09 16:56 ` Thomas Graf
2004-10-20 1:19 ` [PATCH 0/5] PKT_SCHED: Convert Qdiscs to use generic network statistics/estimator David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041009162602.GA21977@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).