From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [PATCH 5/5] PKT_SCHED: Qdisc are not supposed to dump TCA_STATS themselves Date: Sat, 9 Oct 2004 18:26:02 +0200 Sender: netdev-bounce@oss.sgi.com Message-ID: <20041009162602.GA21977@postel.suug.ch> References: <20041007010146.GA18621@postel.suug.ch> <20041007010819.GF18621@postel.suug.ch> <1097336911.1051.149.camel@jzny.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev@oss.sgi.com Return-path: To: jamal Content-Disposition: inline In-Reply-To: <1097336911.1051.149.camel@jzny.localdomain> Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org > 1-4 look good. > > Caveat to note Dave: both old TC_STAT as well as new TC_STAT2 will be > generated. Newer software can ignore TC_STAT and older s/ware can ignore > TC_STAT2. Correct, I tested all these cases and it works perfectly fine. I also completed porting TCA_XSTATS to the new gnet_stats by introducing dump_stats to Qdisc_ops. I ported your requeues patch and added a missing update in SFQ qdisc. I will send those changes once these have been approved. I will do the same for classes and classifiers, although we will have to talk about it a little as soon as you feel better again. I guess the classifier part will involve changing the action code. > patch 5 is a fix thats independent to 1-4 and should be applied > regardless of the status of 1-4 Right, same for the cbq fix I sent a bit later which I have no clue how it is possible that such a major bug can live for so long, I've been triggering this bug for over 3 years and didn't notice anything until now :->